mbox series

[5.4,0/1] nfsd: Ensure knfsd shuts down when the "nfsd" pseudofs is unmounted

Message ID 20230123152822.868326-1-ntsironis@arrikto.com (mailing list archive)
Headers show
Series nfsd: Ensure knfsd shuts down when the "nfsd" pseudofs is unmounted | expand

Message

Nikos Tsironis Jan. 23, 2023, 3:28 p.m. UTC
The bug that upstream commit c6c7f2a84da45 ("nfsd: Ensure knfsd shuts
down when the "nfsd" pseudofs is unmounted") fixes in kernel v5.13
exists in kernel v5.4 too.

That is, knfsd threads are left behind once the nfsd pseudofs is
unmounted, e.g. when the container is killed.

I backported the patch to kernel v5.4, and tested it.

Trond Myklebust (1):
  nfsd: Ensure knfsd shuts down when the "nfsd" pseudofs is unmounted

 fs/nfsd/netns.h     |  6 +++---
 fs/nfsd/nfs4state.c |  8 +-------
 fs/nfsd/nfsctl.c    | 14 ++------------
 fs/nfsd/nfsd.h      |  3 +--
 fs/nfsd/nfssvc.c    | 35 ++++++++++++++++++++++++++++++++++-
 5 files changed, 41 insertions(+), 25 deletions(-)

Comments

Chuck Lever Jan. 23, 2023, 3:42 p.m. UTC | #1
> On Jan 23, 2023, at 10:28 AM, Nikos Tsironis <ntsironis@arrikto.com> wrote:
> 
> The bug that upstream commit c6c7f2a84da45 ("nfsd: Ensure knfsd shuts
> down when the "nfsd" pseudofs is unmounted") fixes in kernel v5.13
> exists in kernel v5.4 too.
> 
> That is, knfsd threads are left behind once the nfsd pseudofs is
> unmounted, e.g. when the container is killed.
> 
> I backported the patch to kernel v5.4, and tested it.

Nikos, thanks for taking care of this!


> Trond Myklebust (1):
>  nfsd: Ensure knfsd shuts down when the "nfsd" pseudofs is unmounted
> 
> fs/nfsd/netns.h     |  6 +++---
> fs/nfsd/nfs4state.c |  8 +-------
> fs/nfsd/nfsctl.c    | 14 ++------------
> fs/nfsd/nfsd.h      |  3 +--
> fs/nfsd/nfssvc.c    | 35 ++++++++++++++++++++++++++++++++++-
> 5 files changed, 41 insertions(+), 25 deletions(-)
> 
> -- 
> 2.30.2
> 

--
Chuck Lever
Greg KH Jan. 30, 2023, 10:10 a.m. UTC | #2
On Mon, Jan 23, 2023 at 03:42:55PM +0000, Chuck Lever III wrote:
> 
> 
> > On Jan 23, 2023, at 10:28 AM, Nikos Tsironis <ntsironis@arrikto.com> wrote:
> > 
> > The bug that upstream commit c6c7f2a84da45 ("nfsd: Ensure knfsd shuts
> > down when the "nfsd" pseudofs is unmounted") fixes in kernel v5.13
> > exists in kernel v5.4 too.
> > 
> > That is, knfsd threads are left behind once the nfsd pseudofs is
> > unmounted, e.g. when the container is killed.
> > 
> > I backported the patch to kernel v5.4, and tested it.
> 
> Nikos, thanks for taking care of this!

Both now queued up, thanks.

greg k-h