mbox series

[RFC,0/7] Possible NFSD COPY clean-ups

Message ID 20240828174001.322745-9-cel@kernel.org (mailing list archive)
Headers show
Series Possible NFSD COPY clean-ups | expand

Message

Chuck Lever Aug. 28, 2024, 5:40 p.m. UTC
From: Chuck Lever <chuck.lever@oracle.com>

While working on OFFLOAD_STATUS and other potential improvements to
Linux NFS's COPY offload implementation, I've come up with a few
server-side observability enhancements and one or two possible bug
fixes. These are candidates to merge for v6.12.

Comments welcome.

Chuck Lever (7):
  NFSD: Async COPY result needs to return a write verifier
  NFSD: Limit the number of concurrent async COPY operations
  NFSD: Display copy stateids with conventional print formatting
  NFSD: Record the callback stateid in copy tracepoints
  NFSD: Clean up extra whitespace in trace_nfsd_copy_done
  NFSD: Document callback stateid laundering
  NFSD: Wrap async copy operations with trace points

 fs/nfsd/netns.h     |  1 +
 fs/nfsd/nfs4proc.c  | 38 +++++++++---------
 fs/nfsd/nfs4state.c | 37 ++++++++++++-----
 fs/nfsd/trace.h     | 97 +++++++++++++++++++++++++++++++++++++++++----
 fs/nfsd/xdr4.h      |  1 +
 5 files changed, 137 insertions(+), 37 deletions(-)

Comments

Jeff Layton Aug. 29, 2024, 12:48 p.m. UTC | #1
On Wed, 2024-08-28 at 13:40 -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> While working on OFFLOAD_STATUS and other potential improvements to
> Linux NFS's COPY offload implementation, I've come up with a few
> server-side observability enhancements and one or two possible bug
> fixes. These are candidates to merge for v6.12.
> 
> Comments welcome.
> 
> Chuck Lever (7):
>   NFSD: Async COPY result needs to return a write verifier
>   NFSD: Limit the number of concurrent async COPY operations
>   NFSD: Display copy stateids with conventional print formatting
>   NFSD: Record the callback stateid in copy tracepoints
>   NFSD: Clean up extra whitespace in trace_nfsd_copy_done
>   NFSD: Document callback stateid laundering
>   NFSD: Wrap async copy operations with trace points
> 
>  fs/nfsd/netns.h     |  1 +
>  fs/nfsd/nfs4proc.c  | 38 +++++++++---------
>  fs/nfsd/nfs4state.c | 37 ++++++++++++-----
>  fs/nfsd/trace.h     | 97 +++++++++++++++++++++++++++++++++++++++++----
>  fs/nfsd/xdr4.h      |  1 +
>  5 files changed, 137 insertions(+), 37 deletions(-)
> 

I sent some R-b's already but the rest of the series looks fine to me.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Chuck Lever III Aug. 30, 2024, 7:31 p.m. UTC | #2
> On Aug 28, 2024, at 1:40 PM, cel@kernel.org wrote:
> 
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> While working on OFFLOAD_STATUS and other potential improvements to
> Linux NFS's COPY offload implementation, I've come up with a few
> server-side observability enhancements and one or two possible bug
> fixes. These are candidates to merge for v6.12.
> 
> Comments welcome.
> 
> Chuck Lever (7):
>  NFSD: Async COPY result needs to return a write verifier
>  NFSD: Limit the number of concurrent async COPY operations
>  NFSD: Display copy stateids with conventional print formatting
>  NFSD: Record the callback stateid in copy tracepoints
>  NFSD: Clean up extra whitespace in trace_nfsd_copy_done
>  NFSD: Document callback stateid laundering
>  NFSD: Wrap async copy operations with trace points
> 
> fs/nfsd/netns.h     |  1 +
> fs/nfsd/nfs4proc.c  | 38 +++++++++---------
> fs/nfsd/nfs4state.c | 37 ++++++++++++-----
> fs/nfsd/trace.h     | 97 +++++++++++++++++++++++++++++++++++++++++----
> fs/nfsd/xdr4.h      |  1 +
> 5 files changed, 137 insertions(+), 37 deletions(-)
> 
> -- 
> 2.46.0

I've applied all but "NFSD: Document callback stateid laundering"
to nfsd-next.

--
Chuck Lever