[0/3] bugfix for c_show/e_show

Message

yangerkun Oct. 21, 2024, 2:23 p.m. UTC

Yang Erkun (3):
  nfsd: make sure exp active before svc_export_show
  SUNRPC: make sure cache entry active before cache_show
  nfsd: release svc_expkey/svc_export with rcu_work

 fs/nfsd/export.c   | 36 +++++++++++++++++++++++++++++-------
 fs/nfsd/export.h   |  4 ++--
 net/sunrpc/cache.c |  4 +++-
 3 files changed, 34 insertions(+), 10 deletions(-)

Comments

Jeff Layton Oct. 21, 2024, 2:42 p.m. UTC | #1

On Mon, 2024-10-21 at 22:23 +0800, Yang Erkun wrote:
> Yang Erkun (3):
>   nfsd: make sure exp active before svc_export_show
>   SUNRPC: make sure cache entry active before cache_show
>   nfsd: release svc_expkey/svc_export with rcu_work
> 
>  fs/nfsd/export.c   | 36 +++++++++++++++++++++++++++++-------
>  fs/nfsd/export.h   |  4 ++--
>  net/sunrpc/cache.c |  4 +++-
>  3 files changed, 34 insertions(+), 10 deletions(-)
> 

TIL about rcu_work! That seems like a nice clean solution for #3. All 3
patches look fine to me. You can add:

Reviewed-by: Jeff Layton <[e-mail]>

One thing though. We had very little RCU in nfsd in 2012, so these
problems likely got introduced much later than 2.6.12. cache_get_rcu()
got added in 2018, for instance. We may want a more reasonable Fixes:
tag.

Chuck Lever Oct. 21, 2024, 2:52 p.m. UTC | #2

> On Oct 21, 2024, at 10:42 AM, Jeff Layton <[e-mail]> wrote:
> 
> One thing though. We had very little RCU in nfsd in 2012, so these
> problems likely got introduced much later than 2.6.12. cache_get_rcu()
> got added in 2018, for instance. We may want a more reasonable Fixes:
> tag.

In cases where we don't have a specific commit ID, you
can use Cc: [e-mail] <mailto:[e-mail]> without a Fixes: tag.

But, I agree with Jeff; let's do a little research first
to see if we can identify a culprit commit, just for due
diligence.


--
Chuck Lever