mbox series

[v4,0/9] Fix XDR encoding near page boundaries

Message ID 20241231002901.12725-1-cel@kernel.org (mailing list archive)
Headers show
Series Fix XDR encoding near page boundaries | expand

Message

Chuck Lever Dec. 31, 2024, 12:28 a.m. UTC
From: Chuck Lever <chuck.lever@oracle.com>

Refresh the patch series to address the longstanding bug pointed out
by J David and Rick Macklem.

Changes since v2:
- Address same issue in NFSv4 READLINK and SECINFO operations
- Update kdoc comment for xdr_reserve_space()

Chuck Lever (9):
  NFSD: Encode COMPOUND operation status on page boundaries
  NFSD: Insulate nfsd4_encode_read() from page boundaries in the encode
    buffer
  NFSD: Insulate nfsd4_encode_read_plus() from page boundaries in the
    encode buffer
  NFSD: Insulate nfsd4_encode_read_plus_data() from page boundaries in
    the encode buffer
  NFSD: Insulate nfsd4_encode_fattr4() from page boundaries in the
    encode buffer
  NFSD: Insulate nfsd4_encode_readlink() from page boundaries in the
    encode buffer
  NFSD: Refactor nfsd4_do_encode_secinfo() again
  NFSD: Insulate nfsd4_encode_secinfo() from page boundaries in the
    encode buffer
  SUNRPC: Document validity guarantees of the pointer returned by
    reserve_space

 fs/nfsd/nfs4xdr.c | 214 +++++++++++++++++++++++++---------------------
 net/sunrpc/xdr.c  |   6 ++
 2 files changed, 122 insertions(+), 98 deletions(-)

Comments

Jeff Layton Jan. 2, 2025, 1:23 p.m. UTC | #1
On Mon, 2024-12-30 at 19:28 -0500, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> Refresh the patch series to address the longstanding bug pointed out
> by J David and Rick Macklem.
> 
> Changes since v2:
> - Address same issue in NFSv4 READLINK and SECINFO operations
> - Update kdoc comment for xdr_reserve_space()
> 
> Chuck Lever (9):
>   NFSD: Encode COMPOUND operation status on page boundaries
>   NFSD: Insulate nfsd4_encode_read() from page boundaries in the encode
>     buffer
>   NFSD: Insulate nfsd4_encode_read_plus() from page boundaries in the
>     encode buffer
>   NFSD: Insulate nfsd4_encode_read_plus_data() from page boundaries in
>     the encode buffer
>   NFSD: Insulate nfsd4_encode_fattr4() from page boundaries in the
>     encode buffer
>   NFSD: Insulate nfsd4_encode_readlink() from page boundaries in the
>     encode buffer
>   NFSD: Refactor nfsd4_do_encode_secinfo() again
>   NFSD: Insulate nfsd4_encode_secinfo() from page boundaries in the
>     encode buffer
>   SUNRPC: Document validity guarantees of the pointer returned by
>     reserve_space
> 
>  fs/nfsd/nfs4xdr.c | 214 +++++++++++++++++++++++++---------------------
>  net/sunrpc/xdr.c  |   6 ++
>  2 files changed, 122 insertions(+), 98 deletions(-)
> 

Reviewed-by: Jeff Layton <jlayton@kernel.org>