[0/4] nfs-utils: nfsdctl fixups

Message

Olga Kornievskaia Feb. 5, 2025, 3:43 p.m. UTC

Static memory allocations in the path of creating knfsd listeners
has lead to either buffer over flow errors or failure to start
the listener when really long hostname are being used.

Furthermore, when listeners were failed to be created knfsd
threads were still started (with no working listeners). Also,
when threads were not started but we still had already added
they were not cleaned up. 

This patch series attempts to address the said issues.

(note first patch was set as standalone previous and included
here without change).

Olga Kornievskaia (4):
  nfs-utils: nfsdctl: fix update_listeners
  nfs-utils: nfsdctl: fix autostart
  nfs-utils: nfsdctl: cleanup listeners if some failed
  nfs-utils: nfsdctl: fix host-limited add listener

 utils/nfsdctl/nfsdctl.c | 68 +++++++++++++++++++++++++++--------------
 1 file changed, 45 insertions(+), 23 deletions(-)

Comments

Steve Dickson Feb. 7, 2025, 10:31 a.m. UTC | #1

On 2/5/25 10:43 AM, Olga Kornievskaia wrote:
> Static memory allocations in the path of creating knfsd listeners
> has lead to either buffer over flow errors or failure to start
> the listener when really long hostname are being used.
> 
> Furthermore, when listeners were failed to be created knfsd
> threads were still started (with no working listeners). Also,
> when threads were not started but we still had already added
> they were not cleaned up.
> 
> This patch series attempts to address the said issues.
> 
> (note first patch was set as standalone previous and included
> here without change).
> 
> Olga Kornievskaia (4):
>    nfs-utils: nfsdctl: fix update_listeners
>    nfs-utils: nfsdctl: fix autostart
>    nfs-utils: nfsdctl: cleanup listeners if some failed
>    nfs-utils: nfsdctl: fix host-limited add listener
> 
>   utils/nfsdctl/nfsdctl.c | 68 +++++++++++++++++++++++++++--------------
>   1 file changed, 45 insertions(+), 23 deletions(-)
> 
Committed (tag: nfs-utils-2-8-3-rc6)

steved.