Message ID | 0963d6fa00685c2810cd1d5996eb4853a2949057.1539889215.git.bcodding@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [1/2,v2] nfs: Fix a missed page unlock after pg_doio() | expand |
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c index 7e6425791388..a592abb62873 100644 --- a/fs/nfs/pagelist.c +++ b/fs/nfs/pagelist.c @@ -1174,10 +1174,6 @@ int nfs_pageio_add_request(struct nfs_pageio_descriptor *desc, return 1; out_failed: - /* remember fatal errors */ - if (nfs_error_is_fatal(desc->pg_error)) - nfs_context_set_write_error(req->wb_context, - desc->pg_error); nfs_pageio_error_cleanup(desc); return 0; }
We don't need to call this in the direct, read, or pnfs resend paths and the only other caller is the write path in nfs_page_async_flush() which already checks and sets the pg_error on the context. Signed-off-by: Benjamin Coddington <bcodding@redhat.com> --- fs/nfs/pagelist.c | 4 ---- 1 file changed, 4 deletions(-)