diff mbox

kernel panic when mount NFSv4

Message ID 1292879966.7744.4.camel@heimdal.trondhjem.org
State Accepted, archived
Delegated to: Trond Myklebust
Headers show

Commit Message

Trond Myklebust Dec. 20, 2010, 9:19 p.m. UTC
None

Comments

Jonathan Nieder Dec. 14, 2012, 5:39 a.m. UTC | #1
Hi Willy et al,

Please consider

  beb0f0a9fba1 kernel panic when mount NFSv4, 2010-12-20

for application to kernel.org's 2.6.32.y and 2.6.34.y trees.  The
patch was applied upstream during the 2.6.38 merge window, so newer
kernels don't need it.

(Context: <http://bugs.debian.org/695872>.)  Tom Downes (cc-ed)
experienced the bug on a Debian kernel close to 2.6.32.58 and
confirmed that the patch doesn't seem to hurt.

The patch is part of Fedora 13's 2.6.34-based and Fedora 14's
2.6.35-based kernels[1].  It was also included in the RHEL kernel at
some point between 2.6.32-71.29.1.el6 and 2.6.32-131.0.15.el6[2].

Thoughts of all kinds welcome, as always.

Regards,
Jonathan

[1] https://bugzilla.redhat.com/673207
[2] https://oss.oracle.com/git/?p=redpatch.git;a=commit;h=8028cccdc4b1
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Willy Tarreau Dec. 14, 2012, 7:17 a.m. UTC | #2
Hi Jonathan,

On Thu, Dec 13, 2012 at 09:39:58PM -0800, Jonathan Nieder wrote:
> Hi Willy et al,
> 
> Please consider
> 
>   beb0f0a9fba1 kernel panic when mount NFSv4, 2010-12-20
> 
> for application to kernel.org's 2.6.32.y and 2.6.34.y trees.  The
> patch was applied upstream during the 2.6.38 merge window, so newer
> kernels don't need it.
> 
> (Context: <http://bugs.debian.org/695872>.)  Tom Downes (cc-ed)
> experienced the bug on a Debian kernel close to 2.6.32.58 and
> confirmed that the patch doesn't seem to hurt.
> 
> The patch is part of Fedora 13's 2.6.34-based and Fedora 14's
> 2.6.35-based kernels[1].  It was also included in the RHEL kernel at
> some point between 2.6.32-71.29.1.el6 and 2.6.32-131.0.15.el6[2].
> 
> Thoughts of all kinds welcome, as always.

Thank you for all the details, as always :-)

I'm queuing this patch for 2.6.32.61.

Best regards,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
index 10a17a3..5356d95 100644
--- a/net/sunrpc/rpc_pipe.c
+++ b/net/sunrpc/rpc_pipe.c
@@ -466,7 +466,7 @@  static int __rpc_create_common(struct inode *dir, struct dentry *dentry,
 {
 	struct inode *inode;
 
-	BUG_ON(!d_unhashed(dentry));
+	d_drop(dentry);
 	inode = rpc_get_inode(dir->i_sb, mode);
 	if (!inode)
 		goto out_err;