From patchwork Fri Feb 11 15:42:35 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fred Isaman X-Patchwork-Id: 549841 X-Patchwork-Delegate: Trond.Myklebust@netapp.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1BFgmxJ009001 for ; Fri, 11 Feb 2011 15:42:50 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757229Ab1BKPmr (ORCPT ); Fri, 11 Feb 2011 10:42:47 -0500 Received: from mx2.netapp.com ([216.240.18.37]:34575 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757168Ab1BKPmq (ORCPT ); Fri, 11 Feb 2011 10:42:46 -0500 X-IronPort-AV: E=Sophos;i="4.60,455,1291622400"; d="scan'208";a="517210972" Received: from smtp1.corp.netapp.com ([10.57.156.124]) by mx2-out.netapp.com with ESMTP; 11 Feb 2011 07:42:46 -0800 Received: from localhost.localdomain (manjua-lxp.hq.netapp.com [10.58.49.248] (may be forged)) by smtp1.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id p1BFgicJ002511; Fri, 11 Feb 2011 07:42:45 -0800 (PST) From: Fred Isaman To: linux-nfs@vger.kernel.org Cc: Trond Myklebust , "J. Bruce Fields" Subject: [PATCH 1/4] RPC: remove check for impossible condition in rpc_make_runnable Date: Fri, 11 Feb 2011 10:42:35 -0500 Message-Id: <1297438958-24861-2-git-send-email-iisaman@netapp.com> X-Mailer: git-send-email 1.7.2.1 In-Reply-To: <1297438958-24861-1-git-send-email-iisaman@netapp.com> References: <1297438958-24861-1-git-send-email-iisaman@netapp.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 11 Feb 2011 15:42:50 +0000 (UTC) diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index 243fc09..bb8f54f 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c @@ -285,15 +285,8 @@ static void rpc_make_runnable(struct rpc_task *task) if (rpc_test_and_set_running(task)) return; if (RPC_IS_ASYNC(task)) { - int status; - INIT_WORK(&task->u.tk_work, rpc_async_schedule); - status = queue_work(rpciod_workqueue, &task->u.tk_work); - if (status < 0) { - printk(KERN_WARNING "RPC: failed to add task to queue: error: %d!\n", status); - task->tk_status = status; - return; - } + queue_work(rpciod_workqueue, &task->u.tk_work); } else wake_up_bit(&task->tk_runstate, RPC_TASK_QUEUED); }