From patchwork Wed Apr 27 19:47:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bryan Schumaker X-Patchwork-Id: 737471 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3RKL4ej017892 for ; Wed, 27 Apr 2011 20:21:05 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339Ab1D0TrV (ORCPT ); Wed, 27 Apr 2011 15:47:21 -0400 Received: from mx2.netapp.com ([216.240.18.37]:21819 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812Ab1D0TrU (ORCPT ); Wed, 27 Apr 2011 15:47:20 -0400 X-IronPort-AV: E=Sophos;i="4.64,275,1301900400"; d="scan'208";a="544136740" Received: from smtp1.corp.netapp.com ([10.57.156.124]) by mx2-out.netapp.com with ESMTP; 27 Apr 2011 12:47:20 -0700 Received: from davros.hq.netapp.com (robertmw-lxp.hq.netapp.com [10.30.16.228] (may be forged)) by smtp1.corp.netapp.com (8.13.1/8.13.1/NTAP-1.6) with ESMTP id p3RJlHpQ027445; Wed, 27 Apr 2011 12:47:18 -0700 (PDT) From: bjschuma@netapp.com To: bfields@fieldses.org Cc: linux-nfs@vger.kernel.org, Bryan Schumaker Subject: [PATCH 1/3] NFSD: Remove setting unused variable in nfsd_vfs_read() Date: Wed, 27 Apr 2011 15:47:14 -0400 Message-Id: <1303933636-22134-1-git-send-email-bjschuma@netapp.com> X-Mailer: git-send-email 1.7.4.4 MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 27 Apr 2011 20:21:05 +0000 (UTC) From: Bryan Schumaker Compiling gave me this warning: fs/nfsd/vfs.c: In function ‘nfsd_vfs_read’: fs/nfsd/vfs.c:880:16: warning: variable ‘inode’ set but not used [-Wunused-but-set-variable] I discovered that a local variable "inode" was being set towards the beginning of nfsd_vfs_read() and then ignored for the rest of the function. Signed-off-by: Bryan Schumaker --- fs/nfsd/vfs.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 129f3c9..07b1e58 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -877,13 +877,11 @@ static __be32 nfsd_vfs_read(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file, loff_t offset, struct kvec *vec, int vlen, unsigned long *count) { - struct inode *inode; mm_segment_t oldfs; __be32 err; int host_err; err = nfserr_perm; - inode = file->f_path.dentry->d_inode; if (file->f_op->splice_read && rqstp->rq_splice_ok) { struct splice_desc sd = {