diff mbox

[1/2] mountd: Fixed strcmp usage in in insert groups.

Message ID 1312225347-11282-1-git-send-email-treinish@linux.vnet.ibm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Matthew Treinish Aug. 1, 2011, 7:02 p.m. UTC
Fixed the usage of strcmp in the duplicate check in insert groups. Fixes an
issue with showmount and other commands that required the group information.

Signed-off-by: Matthew Treinish <treinish@linux.vnet.ibm.com>
---
 utils/mountd/mountd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Steve Dickson Aug. 3, 2011, 5:45 p.m. UTC | #1
On 08/01/2011 03:02 PM, Matthew Treinish wrote:
> Fixed the usage of strcmp in the duplicate check in insert groups. Fixes an
> issue with showmount and other commands that required the group information.
> 
> Signed-off-by: Matthew Treinish <treinish@linux.vnet.ibm.com>
Committed... 

steved.

> ---
>  utils/mountd/mountd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
> index 035624c..bcf5080 100644
> --- a/utils/mountd/mountd.c
> +++ b/utils/mountd/mountd.c
> @@ -633,7 +633,7 @@ static void insert_group(struct exportnode *e, char *newname)
>  	struct groupnode *g;
>  
>  	for (g = e->ex_groups; g; g = g->gr_next)
> -		if (strcmp(g->gr_name, newname))
> +		if (!strcmp(g->gr_name, newname))
>  			return;
>  
>  	g = xmalloc(sizeof(*g));
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
index 035624c..bcf5080 100644
--- a/utils/mountd/mountd.c
+++ b/utils/mountd/mountd.c
@@ -633,7 +633,7 @@  static void insert_group(struct exportnode *e, char *newname)
 	struct groupnode *g;
 
 	for (g = e->ex_groups; g; g = g->gr_next)
-		if (strcmp(g->gr_name, newname))
+		if (!strcmp(g->gr_name, newname))
 			return;
 
 	g = xmalloc(sizeof(*g));