From patchwork Sat Aug 6 15:52:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Tao X-Patchwork-Id: 1041752 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p76FqgN9008431 for ; Sat, 6 Aug 2011 15:53:22 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753326Ab1HFPxW (ORCPT ); Sat, 6 Aug 2011 11:53:22 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:41908 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899Ab1HFPxV (ORCPT ); Sat, 6 Aug 2011 11:53:21 -0400 Received: by mail-pz0-f42.google.com with SMTP id 37so5621454pzk.1 for ; Sat, 06 Aug 2011 08:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=HuZcDvdzxEwhhIjXX14JapkzXKnjTXmLEl0shEH6acg=; b=gn5Vb2m9Fv/rbDYndvprcvEpgCdclQrQIBafpYP+7ku8PVAtaaRHlB7vWgNy9vVju1 azNK302KUEZG+AZ14/+D3tDB12NhaqYrcDcLM4dGuHZFWn8Ma/jte0jD2HllqnqMHGLC 4sGFiCPTMsKmGZxFO89Aho4087P1wW7Wjj0f4= Received: by 10.142.248.36 with SMTP id v36mr683543wfh.414.1312646001191; Sat, 06 Aug 2011 08:53:21 -0700 (PDT) Received: from debian-sid.localdomain ([123.118.148.226]) by mx.google.com with ESMTPS id l7sm4280038pbh.42.2011.08.06.08.53.15 (version=SSLv3 cipher=OTHER); Sat, 06 Aug 2011 08:53:20 -0700 (PDT) From: Peng Tao To: linux-nfs@vger.kernel.org Cc: rees@umich.edu, bhalevy@tonian.com, Trond.Myklebust@netapp.com, Peng Tao Subject: [PATCH 2/2] pNFS: deal with ld read failure Date: Sat, 6 Aug 2011 08:52:14 -0700 Message-Id: <1312645934-4436-3-git-send-email-bergwolf@gmail.com> X-Mailer: git-send-email 1.7.1.262.g5ef3d In-Reply-To: <1312645934-4436-1-git-send-email-bergwolf@gmail.com> References: <1312645934-4436-1-git-send-email-bergwolf@gmail.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sat, 06 Aug 2011 15:53:23 +0000 (UTC) For pnfs pagelist read failure, we need to pg_recoalesce and resend IO to mds. Signed-off-by: Peng Tao --- fs/nfs/internal.h | 2 ++ fs/nfs/pnfs.c | 18 ++++++++++++++---- fs/nfs/read.c | 3 ++- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index 62f183d..78b662e 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h @@ -307,6 +307,8 @@ extern int nfs_generic_flush(struct nfs_pageio_descriptor *desc, struct list_head *head); extern int do_nfs_writepage(struct page *page, struct writeback_control *wbc, struct nfs_pageio_descriptor *pgio); +extern void nfs_pageio_init_read_mds(struct nfs_pageio_descriptor *pgio, + struct inode *inode); extern void nfs_pageio_init_write_mds(struct nfs_pageio_descriptor *pgio, struct inode *inode, int ioflags); extern void nfs_pageio_reset_write_mds(struct nfs_pageio_descriptor *pgio); diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c index 08aba45..66fc854 100644 --- a/fs/nfs/pnfs.c +++ b/fs/nfs/pnfs.c @@ -1300,7 +1300,7 @@ EXPORT_SYMBOL_GPL(pnfs_generic_pg_writepages); int pnfs_ld_read_done(struct nfs_read_data *data) { - int status; + struct nfs_pageio_descriptor pgio; if (!data->pnfs_error) { __nfs4_read_done_cb(data); @@ -1309,11 +1309,21 @@ pnfs_ld_read_done(struct nfs_read_data *data) return 0; } + put_lseg(data->lseg); + data->lseg = NULL; dprintk("%s: pnfs_error=%d, retry via MDS\n", __func__, data->pnfs_error); - status = nfs_initiate_read(data, NFS_CLIENT(data->inode), - data->mds_ops); - return status ? : -EAGAIN; + nfs_pageio_init_read_mds(&pgio, data->inode); + pgio.pg_recoalesce = 1; + while (!list_empty(&data->pages)) { + struct nfs_page *req = nfs_list_entry(data->pages.next); + + nfs_pageio_add_request(&pgio, req); + } + nfs_pageio_complete(&pgio); + nfs_readdata_release(data); + + return 0; } EXPORT_SYMBOL_GPL(pnfs_ld_read_done); diff --git a/fs/nfs/read.c b/fs/nfs/read.c index 2171c04..2484131 100644 --- a/fs/nfs/read.c +++ b/fs/nfs/read.c @@ -112,12 +112,13 @@ static void nfs_readpage_truncate_uninitialised_page(struct nfs_read_data *data) } } -static void nfs_pageio_init_read_mds(struct nfs_pageio_descriptor *pgio, +void nfs_pageio_init_read_mds(struct nfs_pageio_descriptor *pgio, struct inode *inode) { nfs_pageio_init(pgio, inode, &nfs_pageio_read_ops, NFS_SERVER(inode)->rsize, 0); } +EXPORT_SYMBOL_GPL(nfs_pageio_init_read_mds); void nfs_pageio_reset_read_mds(struct nfs_pageio_descriptor *pgio) {