diff mbox

mount.nfs: submarvellous messages from mount.nfs

Message ID 1313496159-4281-1-git-send-email-steved@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Steve Dickson Aug. 16, 2011, 12:02 p.m. UTC 
From: Max Matveev <makc@redhat.com>

Consider a setup where mountd on the server is controlled via
tcp_wrappers (usual RHEL setup) and will not process calls from a
particular client because of something in /etc/hosts.deny.

When such client attempts to do v3 mount, the error message printed
by mount.nfs is misleading.

This patch changes that error message from:
    mount.nfs: Argument list too long
to
    mount.nfs: access denied by server while mounting server:/export

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 utils/mount/stropts.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Steve Dickson Aug. 16, 2011, 4:46 p.m. UTC | #1 
On 08/16/2011 08:02 AM, Steve Dickson wrote:
> From: Max Matveev <makc@redhat.com>
> 
> Consider a setup where mountd on the server is controlled via
> tcp_wrappers (usual RHEL setup) and will not process calls from a
> particular client because of something in /etc/hosts.deny.
> 
> When such client attempts to do v3 mount, the error message printed
> by mount.nfs is misleading.
> 
> This patch changes that error message from:
>     mount.nfs: Argument list too long
> to
>     mount.nfs: access denied by server while mounting server:/export
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...

steved.

> ---
>  utils/mount/stropts.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index f1aa503..4d023d6 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -538,6 +538,8 @@ nfs_rewrite_pmap_mount_options(struct mount_options *options)
>  		errno = ESPIPE;
>  		if (rpc_createerr.cf_stat == RPC_PROGNOTREGISTERED)
>  			errno = EOPNOTSUPP;
> +		else if (rpc_createerr.cf_stat == RPC_AUTHERROR)
> +			errno = EACCES;
>  		else if (rpc_createerr.cf_error.re_errno != 0)
>  			errno = rpc_createerr.cf_error.re_errno;
>  		return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index f1aa503..4d023d6 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -538,6 +538,8 @@  nfs_rewrite_pmap_mount_options(struct mount_options *options)
 		errno = ESPIPE;
 		if (rpc_createerr.cf_stat == RPC_PROGNOTREGISTERED)
 			errno = EOPNOTSUPP;
+		else if (rpc_createerr.cf_stat == RPC_AUTHERROR)
+			errno = EACCES;
 		else if (rpc_createerr.cf_error.re_errno != 0)
 			errno = rpc_createerr.cf_error.re_errno;
 		return 0;