From patchwork Sat Oct 27 12:33:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1655371 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 9CBBDDFAC4 for ; Sat, 27 Oct 2012 12:40:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755951Ab2J0MkB (ORCPT ); Sat, 27 Oct 2012 08:40:01 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:47879 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755619Ab2J0MeV (ORCPT ); Sat, 27 Oct 2012 08:34:21 -0400 Received: by mail-gh0-f174.google.com with SMTP id g15so699677ghb.19 for ; Sat, 27 Oct 2012 05:34:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=KdSjVgJJnBluV1Q63lD0NnYk4CvxIqyRPl1Dcq9U4mY=; b=IjVM7ktxrOcHwgEdLKxsxtaStNeFzYjeND99jRC0jjuEIStSYmV2bisQ+BCYHqCqzA cPS/JmrFOGOZGXBI6Cfi0uUudte5IYm6Ioc3/2a+ZYmkRn8IB1kpnww6jrdhcnRQpKPS 9X9CeG6mC96EcNi9dIg3itbOg/kIHsmVwMsRGelAth1SoShZD7XqzZudhs2CrmYY0PTo Gaw/98vplOe6MgKWoyZGR2rOneExxSpp8sjTn6vTj2+SxIqSHxRfkB6eihzmIJ1Yj4JJ pnKdC9jdNk+9cewQSVC6+HGGvTfmsnIkm7OnBQoNwI6mx2yTIVtpNIhI/KmAG7rJ1SeM RFBg== Received: by 10.236.86.73 with SMTP id v49mr25270228yhe.31.1351341261395; Sat, 27 Oct 2012 05:34:21 -0700 (PDT) Received: from salusa.poochiereds.net (cpe-107-015-110-129.nc.res.rr.com. [107.15.110.129]) by mx.google.com with ESMTPS id f15sm4124613yhi.11.2012.10.27.05.34.19 (version=SSLv3 cipher=OTHER); Sat, 27 Oct 2012 05:34:20 -0700 (PDT) From: Jeff Layton To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, michael.brantley@deshaw.com, hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com Subject: [PATCH v8 17/32] vfs: make fchmodat retry once on ESTALE errors Date: Sat, 27 Oct 2012 08:33:24 -0400 Message-Id: <1351341219-17837-18-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1351341219-17837-1-git-send-email-jlayton@redhat.com> References: <1351341219-17837-1-git-send-email-jlayton@redhat.com> X-Gm-Message-State: ALoCoQliovib0YPvkXPaj2T4LqVkST6jWcOE9HVDXyGteNdQRndU2yixJgvCABFjKZpCqKFl5S+t Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Jeff Layton --- fs/open.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fs/open.c b/fs/open.c index a1331f1..06f04bd 100644 --- a/fs/open.c +++ b/fs/open.c @@ -503,12 +503,17 @@ SYSCALL_DEFINE3(fchmodat, int, dfd, const char __user *, filename, umode_t, mode { struct path path; int error; + unsigned int try = 0; + int lookup_flags = LOOKUP_FOLLOW; - error = user_path_at(dfd, filename, LOOKUP_FOLLOW, &path); - if (!error) { + do { + error = user_path_at(dfd, filename, lookup_flags, &path); + if (error) + break; error = chmod_common(&path, mode); path_put(&path); - } + lookup_flags |= LOOKUP_REVAL; + } while (retry_estale(error, try++)); return error; }