From patchwork Mon Nov 5 15:21:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1698951 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id C563F3FCA5 for ; Mon, 5 Nov 2012 15:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932986Ab2KEPbB (ORCPT ); Mon, 5 Nov 2012 10:31:01 -0500 Received: from mail-gh0-f174.google.com ([209.85.160.174]:65208 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932963Ab2KEPWw (ORCPT ); Mon, 5 Nov 2012 10:22:52 -0500 Received: by mail-gh0-f174.google.com with SMTP id g15so1012621ghb.19 for ; Mon, 05 Nov 2012 07:22:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=KdSjVgJJnBluV1Q63lD0NnYk4CvxIqyRPl1Dcq9U4mY=; b=Ul6F5UTIB6UzLhXFWCVJjJh1macqQlgK3F5/VG7WUO5oSv2j90xUq2Fmmo0kkuDe9/ QAPXs/rAUdiA3/U46Szh3VZXG9VAao2/EkoTL3KJB59C8sNj4ca88j0iS95vmoHSJEPX HSwEccXTQ18JloUv9WcYi/oZX9q9P2oxp5ofOmU0oU9QA2+oMe6ML5F3497cXLszYvCk jkk5PP8hgxvqdSXMcekv7Su8/IQDpx/LyahXZgZUhq3o0TJdYJYORtYF6X10Ngf8Pbzw ijSVoiy7MEkCsr5tOygoUwbWY79f+mMCUyt4yh2GIAgzYSRVxA90gaAu4T2aW9AgodMG 0nTA== Received: by 10.236.73.70 with SMTP id u46mr9099677yhd.59.1352128972321; Mon, 05 Nov 2012 07:22:52 -0800 (PST) Received: from salusa.poochiereds.net (cpe-107-015-110-129.nc.res.rr.com. [107.15.110.129]) by mx.google.com with ESMTPS id y18sm12026769anh.15.2012.11.05.07.22.50 (version=SSLv3 cipher=OTHER); Mon, 05 Nov 2012 07:22:51 -0800 (PST) From: Jeff Layton To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, michael.brantley@deshaw.com, hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com Subject: [PATCH v9 17/34] vfs: make fchmodat retry once on ESTALE errors Date: Mon, 5 Nov 2012 10:21:56 -0500 Message-Id: <1352128933-28526-18-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1352128933-28526-1-git-send-email-jlayton@redhat.com> References: <1352128933-28526-1-git-send-email-jlayton@redhat.com> X-Gm-Message-State: ALoCoQkB1UKIgrYkpyadHvyY7MSPKCLMcJMptSH9Fo+AbAtVAHkD3leaVmQDA7TrltwIutEWVgU6 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Jeff Layton --- fs/open.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fs/open.c b/fs/open.c index a1331f1..06f04bd 100644 --- a/fs/open.c +++ b/fs/open.c @@ -503,12 +503,17 @@ SYSCALL_DEFINE3(fchmodat, int, dfd, const char __user *, filename, umode_t, mode { struct path path; int error; + unsigned int try = 0; + int lookup_flags = LOOKUP_FOLLOW; - error = user_path_at(dfd, filename, LOOKUP_FOLLOW, &path); - if (!error) { + do { + error = user_path_at(dfd, filename, lookup_flags, &path); + if (error) + break; error = chmod_common(&path, mode); path_put(&path); - } + lookup_flags |= LOOKUP_REVAL; + } while (retry_estale(error, try++)); return error; }