From patchwork Mon Nov 5 15:21:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1698891 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 5405BDF2AB for ; Mon, 5 Nov 2012 15:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933005Ab2KEPW6 (ORCPT ); Mon, 5 Nov 2012 10:22:58 -0500 Received: from mail-ye0-f174.google.com ([209.85.213.174]:61085 "EHLO mail-ye0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932992Ab2KEPW4 (ORCPT ); Mon, 5 Nov 2012 10:22:56 -0500 Received: by mail-ye0-f174.google.com with SMTP id m12so1017195yen.19 for ; Mon, 05 Nov 2012 07:22:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=8xZ0ZyHv4vg6TdEyxt//DyDlnCdmumHIjrM1wJfkfhM=; b=XMS8pNlLqMwNqkLB2CewPvQetN9wkWZWlgHdGkRQZIdKvOYKSBFf6KcvxAvx07xb57 eKooWQMOMiew0KchmL3zJs7C1hKyzAb7SKs19CLE21KaF/MElI+vvHf84KPs15d71tLt Hf558WcYRudREjyb6aGfbDJvgnM33ODccXG3jJ7A474wkFJtPY9Nf/Stds+sIdALw554 6OXjsraBR1/OazmvBZhiCXFO357yixLM87FGHgEmaln0YbVPloDzPUfalbiKSVbXE+hQ 3KS3NK1zLiaBqM1jPbFQSw7ONjG7s/wxWM7orqvj8kP3exzXlGnwsLQGn/sHuuZJFK9O /R0A== Received: by 10.236.145.103 with SMTP id o67mr9234753yhj.131.1352128976079; Mon, 05 Nov 2012 07:22:56 -0800 (PST) Received: from salusa.poochiereds.net (cpe-107-015-110-129.nc.res.rr.com. [107.15.110.129]) by mx.google.com with ESMTPS id y18sm12026769anh.15.2012.11.05.07.22.54 (version=SSLv3 cipher=OTHER); Mon, 05 Nov 2012 07:22:55 -0800 (PST) From: Jeff Layton To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, michael.brantley@deshaw.com, hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com Subject: [PATCH v9 19/34] vfs: fix user_statfs to retry once on ESTALE errors Date: Mon, 5 Nov 2012 10:21:58 -0500 Message-Id: <1352128933-28526-20-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1352128933-28526-1-git-send-email-jlayton@redhat.com> References: <1352128933-28526-1-git-send-email-jlayton@redhat.com> X-Gm-Message-State: ALoCoQkHDx0sVgRICcZTXf+5FlpJdJm1aNewEVmIZadGG1Xr4qc4BC05sJzT0PfC2kCVxJKai1h8 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Jeff Layton --- fs/statfs.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/fs/statfs.c b/fs/statfs.c index f8e832e..7b42ca3 100644 --- a/fs/statfs.c +++ b/fs/statfs.c @@ -77,11 +77,19 @@ EXPORT_SYMBOL(vfs_statfs); int user_statfs(const char __user *pathname, struct kstatfs *st) { struct path path; - int error = user_path_at(AT_FDCWD, pathname, LOOKUP_FOLLOW|LOOKUP_AUTOMOUNT, &path); - if (!error) { + int error; + unsigned int try = 0; + unsigned int lookup_flags = LOOKUP_FOLLOW|LOOKUP_AUTOMOUNT; + + do { + error = user_path_at(AT_FDCWD, pathname, lookup_flags, &path); + if (error) + break; + error = vfs_statfs(&path, st); path_put(&path); - } + lookup_flags |= LOOKUP_REVAL; + } while (retry_estale(error, try++)); return error; }