From patchwork Mon Nov 5 15:22:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1698841 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 643FD3FCA5 for ; Mon, 5 Nov 2012 15:29:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932883Ab2KEP3N (ORCPT ); Mon, 5 Nov 2012 10:29:13 -0500 Received: from mail-ye0-f174.google.com ([209.85.213.174]:61085 "EHLO mail-ye0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932993Ab2KEPXD (ORCPT ); Mon, 5 Nov 2012 10:23:03 -0500 Received: by mail-ye0-f174.google.com with SMTP id m12so1017195yen.19 for ; Mon, 05 Nov 2012 07:23:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=BaLayy0j7BRZj+BFE89AhGPqp83yeH/VU2M9ALCrOYc=; b=T3ZSUSVgAtufH9yX4oatZgomJ9WacgWtqSjMy//KH4mnYngXgK8qrUpQ5GqT77xTcd /InkqQ6bkdBLTNtTqZjoCtaHZjQS2yfrhap7xm7AFqld8K8cyCN9qKDPrI6XNn8Z+JT0 ELZgT5Gh1F/9BtZKXMJLHyLVj8HjHSvai9qlSSVO4Z30MbprzgmsolHXnDGeLneA4zhC fVhwQzjZYwqjKaycuouExUs4GVjEmtfZGWEGNIzi2nUp0ugUO1BcxsHKq8yl+VY6LChV R4tn+bX8j7OBjss4orbmpJkm4iEP1emyd9ysmyJUEtp5e5c7/4fCPdJlkxzAZMp5jqQ8 kNgQ== Received: by 10.236.81.209 with SMTP id m57mr9123938yhe.84.1352128983587; Mon, 05 Nov 2012 07:23:03 -0800 (PST) Received: from salusa.poochiereds.net (cpe-107-015-110-129.nc.res.rr.com. [107.15.110.129]) by mx.google.com with ESMTPS id y18sm12026769anh.15.2012.11.05.07.23.01 (version=SSLv3 cipher=OTHER); Mon, 05 Nov 2012 07:23:02 -0800 (PST) From: Jeff Layton To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, michael.brantley@deshaw.com, hch@infradead.org, miklos@szeredi.hu, pstaubach@exagrid.com Subject: [PATCH v9 23/34] vfs: make getxattr retry once on an ESTALE error Date: Mon, 5 Nov 2012 10:22:02 -0500 Message-Id: <1352128933-28526-24-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1352128933-28526-1-git-send-email-jlayton@redhat.com> References: <1352128933-28526-1-git-send-email-jlayton@redhat.com> X-Gm-Message-State: ALoCoQle9y6Ji/3mh3BO8fv4QEFUL32RPnv1aGML1mYkHwixcJ/ohtwuS/fj+DnlCZX8UG3FP7NF Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Jeff Layton --- fs/xattr.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/xattr.c b/fs/xattr.c index 5a9ddba..42284fc 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -486,12 +486,17 @@ SYSCALL_DEFINE4(getxattr, const char __user *, pathname, { struct path path; ssize_t error; + unsigned int try = 0; + unsigned int lookup_flags = LOOKUP_FOLLOW; - error = user_path(pathname, &path); - if (error) - return error; - error = getxattr(path.dentry, name, value, size); - path_put(&path); + do { + error = user_path_at(AT_FDCWD, pathname, lookup_flags, &path); + if (error) + break; + error = getxattr(path.dentry, name, value, size); + path_put(&path); + lookup_flags |= LOOKUP_REVAL; + } while (retry_estale(error, try++)); return error; }