From patchwork Mon Nov 12 20:00:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 1730241 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id E96483FCAE for ; Mon, 12 Nov 2012 20:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752122Ab2KLUBM (ORCPT ); Mon, 12 Nov 2012 15:01:12 -0500 Received: from mail-vb0-f46.google.com ([209.85.212.46]:59742 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752798Ab2KLUBM (ORCPT ); Mon, 12 Nov 2012 15:01:12 -0500 Received: by mail-vb0-f46.google.com with SMTP id ff1so6652181vbb.19 for ; Mon, 12 Nov 2012 12:01:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=owavavzHl5q/hvKZnJix668qz21dIxxpBQ4ULoX11ik=; b=YMElDJATDOumd1jovCDlKWMPIonql+Z6unh5Q964b5UvNKIe6eJhetgx+ausIwRY+H zuVb2V/BeyGnWtbgNOlBwrM3nELfFDt1KwELk28ZXG53u7GRrXGe3m6+c2CBJQH3ZB9z zhR2uP7UVT52y7byu4W8y5supAemOhbnxBc3rzAVk2ATRSC6pDA4iEV66/PK37nEvBVO uH5NV5IRBxK3g+S2cbHMDkrx9kK2ztjPMEUUMXauc3qKU1U72oxL2CJsS/xegcSGkcEO yAePoyiQOQEHSPG3I3ugT2cgTqyZh0+7TrwT2dN+ax0i1/PdJK+Qkqv+ajytNjxfdH2g r50g== Received: by 10.52.27.2 with SMTP id p2mr23566938vdg.85.1352750471687; Mon, 12 Nov 2012 12:01:11 -0800 (PST) Received: from salusa.poochiereds.net (cpe-107-015-110-129.nc.res.rr.com. [107.15.110.129]) by mx.google.com with ESMTPS id dh10sm7390369veb.8.2012.11.12.12.01.10 (version=SSLv3 cipher=OTHER); Mon, 12 Nov 2012 12:01:10 -0800 (PST) From: Jeff Layton To: bfields@fieldses.org Cc: linux-nfs@vger.kernel.org Subject: [PATCH 04/11] nfsd: warn about impending removal of nfsdcld upcall Date: Mon, 12 Nov 2012 15:00:51 -0500 Message-Id: <1352750458-16857-5-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1352750458-16857-1-git-send-email-jlayton@redhat.com> References: <1352750458-16857-1-git-send-email-jlayton@redhat.com> X-Gm-Message-State: ALoCoQn8KYsx32xjxI1jiZ6AfUuTIr0AulXTK3AEY6CMM4vP9pSd7Z13YyrJAk07/u4m0wXT/sBV Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Let's shoot for removing the nfsdcld upcall in 3.10. Most likely, no one is actually using it so I don't expect this warning to fire often (except maybe on misconfigured systems). Signed-off-by: Jeff Layton --- fs/nfsd/nfs4recover.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index 38af615..6aaf5d9 100644 --- a/fs/nfsd/nfs4recover.c +++ b/fs/nfsd/nfs4recover.c @@ -1166,6 +1166,9 @@ nfsd4_client_tracking_init(struct net *net) /* Finally, try to use nfsdcld */ client_tracking_ops = &nfsd4_cld_tracking_ops; + printk(KERN_WARNING "NFSD: the nfsdcld client tracking upcall will be " + "removed in 3.10. Please transition to using " + "nfsdcltrack.\n"); do_init: status = client_tracking_ops->init(net); if (status) {