From patchwork Tue Jan 22 17:26:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 2020051 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id B873CDF2EB for ; Tue, 22 Jan 2013 17:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753629Ab3AVR0z (ORCPT ); Tue, 22 Jan 2013 12:26:55 -0500 Received: from mail-pb0-f52.google.com ([209.85.160.52]:63701 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752622Ab3AVR0y (ORCPT ); Tue, 22 Jan 2013 12:26:54 -0500 Received: by mail-pb0-f52.google.com with SMTP id ro2so4086121pbb.25 for ; Tue, 22 Jan 2013 09:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:from:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=bvm/2bnK4POX7M7kI5JUOdrX2TxyzjaDNxRha/xV7xQ=; b=tlii9dkEyeUhBh2kRdkhr3hRv4d/Sd3EFPqSh6Z8iduVffCI2XzH5cM6/A3RiS7VxA BQYQzXrgstSs2yYoMOQEq46PNTGoJgPSD8q6IK0TMCLcXzWnGJfa2wJvvrWSz5pZofuZ ODtGXFwNwDelFLcv0Nu8FEAaYsTrgQ7WjxBbiHZtcDPsr7sjrGxpfXIpLuJJhVjkffVB /wKTD2POkOzzV/x5OBaWux42zFuQyqwcIUADBVhzdgYCxcMZ/Wpj2NDav2K+Ur4fYBEX Vy/Rlkc6abLd6T0fOeGsN5bDzTqzpMRna/gqCU0F09x9X/2P/NXv6jtCca5cl/ktRBiO Q0fA== X-Received: by 10.68.233.99 with SMTP id tv3mr41145025pbc.64.1358875614292; Tue, 22 Jan 2013 09:26:54 -0800 (PST) Received: from [172.19.241.243] ([172.19.241.243]) by mx.google.com with ESMTPS id im5sm11078066pbc.55.2013.01.22.09.26.50 (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 22 Jan 2013 09:26:53 -0800 (PST) Subject: Re: 3.7.3+: Bad paging request in ip_rcv_finish while running NFS traffic. From: Eric Dumazet To: Ben Greear Cc: netdev , "linux-nfs@vger.kernel.org" In-Reply-To: <1358875020.3464.4006.camel@edumazet-glaptop> References: <50FDADF4.3060601@candelatech.com> <50FDDE35.7070806@candelatech.com> <1358829606.3464.3151.camel@edumazet-glaptop> <50FE2A57.3040804@candelatech.com> <50FEC796.5090404@candelatech.com> <1358875020.3464.4006.camel@edumazet-glaptop> Date: Tue, 22 Jan 2013 09:26:47 -0800 Message-ID: <1358875607.3464.4020.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, 2013-01-22 at 09:17 -0800, Eric Dumazet wrote: > On Tue, 2013-01-22 at 09:08 -0800, Ben Greear wrote: > > > Unfortunately, I hit it again this morning after the first restart of > > my application (which bounces all 3000 interfaces). Memory poisoning > > was disabled. > > Is your NFS traffic using TCP or UDP ? > Oh well, it seems macvlan.c has to skb_drop_dst(skb) before giving skb to netif_rx() --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 68a43fe..4f049ee 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -114,6 +114,7 @@ static int macvlan_broadcast_one(struct sk_buff *skb, if (!skb) return NET_RX_DROP; + skb_dst_drop(skb); if (local) return vlan->forward(dev, skb); @@ -220,6 +221,7 @@ static rx_handler_result_t macvlan_handle_frame(struct sk_buff **pskb) if (!skb) goto out; + skb_dst_drop(skb); skb->dev = dev; skb->pkt_type = PACKET_HOST;