| Message ID | 1359153858-31992-16-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Friday, January 25, 2013 5:44 PM > To: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org; Arnd Bergmann; J. Bruce Fields; > Myklebust, Trond; linux-nfs@vger.kernel.org; netdev@vger.kernel.org > Subject: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf' > > When RPC_DEBUG is unset, the dprintk() macro does nothing, causing the > 'buf' variable in svc_printk to become unused. > Marking it as __maybe_unused avoids a harmless gcc warning. > > Without this patch, building at91_dt_defconfig results in: > > net/sunrpc/svc.c: In function 'svc_printk': > net/sunrpc/svc.c:1051:7: warning: unused variable 'buf' [-Wunused-variable] > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: "J. Bruce Fields" <bfields@redhat.com> > Cc: Trond Myklebust <Trond.Myklebust@netapp.com> > Cc: linux-nfs@vger.kernel.org > Cc: netdev@vger.kernel.org > --- > net/sunrpc/svc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index dbf12ac..b1f5223 > 100644 > --- a/net/sunrpc/svc.c > +++ b/net/sunrpc/svc.c > @@ -1047,7 +1047,7 @@ void svc_printk(struct svc_rqst *rqstp, const char > *fmt, ...) { > struct va_format vaf; > va_list args; > - char buf[RPC_MAX_ADDRBUFLEN]; > + char buf[RPC_MAX_ADDRBUFLEN] __maybe_unused; > > va_start(args, fmt); Alternatively, just declare it using the RPC_IFDEBUG() macro. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index dbf12ac..b1f5223 100644 --- a/net/sunrpc/svc.c +++ b/net/sunrpc/svc.c @@ -1047,7 +1047,7 @@ void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...) { struct va_format vaf; va_list args; - char buf[RPC_MAX_ADDRBUFLEN]; + char buf[RPC_MAX_ADDRBUFLEN] __maybe_unused; va_start(args, fmt);
When RPC_DEBUG is unset, the dprintk() macro does nothing, causing the 'buf' variable in svc_printk to become unused. Marking it as __maybe_unused avoids a harmless gcc warning. Without this patch, building at91_dt_defconfig results in: net/sunrpc/svc.c: In function 'svc_printk': net/sunrpc/svc.c:1051:7: warning: unused variable 'buf' [-Wunused-variable] Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: "J. Bruce Fields" <bfields@redhat.com> Cc: Trond Myklebust <Trond.Myklebust@netapp.com> Cc: linux-nfs@vger.kernel.org Cc: netdev@vger.kernel.org --- net/sunrpc/svc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)