From patchwork Fri Mar 22 02:57:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ycnian@gmail.com X-Patchwork-Id: 2318021 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id B8E4240213 for ; Fri, 22 Mar 2013 03:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566Ab3CVDJQ (ORCPT ); Thu, 21 Mar 2013 23:09:16 -0400 Received: from mail-da0-f41.google.com ([209.85.210.41]:58601 "EHLO mail-da0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677Ab3CVDJP (ORCPT ); Thu, 21 Mar 2013 23:09:15 -0400 Received: by mail-da0-f41.google.com with SMTP id w4so2016548dam.14 for ; Thu, 21 Mar 2013 20:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=8/+ae5d8uHXjNokOVFekkAFxVaJsw8GyLrwTISZulBU=; b=ZGtJ7VTEbm98bChuNVgHGnudKPQgEKTy2Y4FDM3GvuUyflAP3XOEYD4pxWLj2u3De3 4CqSpdhlfcDSc4M2aX6AIuAIK2q905tWVpcuI6cfBEjgqhAS4O+aq61s1Ot2b/RXI1J0 HqjbdgzA3aV0h4cPQIBa/fFDQ69f6BxkRmvsVAFPYNnb9AjtVEkTLR7Cdw8VGi8Sgu/K N1rJSgkDJORFlBwFD6qNHwd1SJQYz7QduV/3OLI+o9CU07hUViG2u+kVUaWL8rkC/uJ/ C3ts4hNEaeuk4q3XHlJ35RoRdwaWPX/KSKGeSaT52HtJ3mC3fM+w0RkJAMnwGN/O6Tsg JXYw== X-Received: by 10.68.228.164 with SMTP id sj4mr168244pbc.180.1363921754652; Thu, 21 Mar 2013 20:09:14 -0700 (PDT) Received: from localhost ([159.226.5.132]) by mx.google.com with ESMTPS id xs10sm1055903pac.8.2013.03.21.20.09.11 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 21 Mar 2013 20:09:13 -0700 (PDT) From: ycnian@gmail.com To: Trond.Myklebust@netapp.com Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Yanchuan Nian Subject: nfsv4.1 client refuses to suspend Date: Fri, 22 Mar 2013 10:57:21 +0800 Message-Id: <1363921041-5042-1-git-send-email-ycnian@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org nfsv4.1 client suspending fails with such info Freezing of tasks failed after 20.00 seconds (1 tasks refusing to freeze, wq_busy=0): nfsv4.1-svc S ffff88007889f2e0 0 3191 2 0x00000080 ffff88007b2f3e28 0000000000000046 ffff88007b2f2010 00000000000127c0 ffff880079b08000 00000000000127c0 ffff88007b2f3fd8 00000000000127c0 ffff88007b2f3fd8 00000000000127c0 ffffffff81a14410 ffff880079b08000 Call Trace: [] schedule+0x64/0x66 [] nfs41_callback_svc+0x100/0x129 [nfsv4] [] ? wake_up_bit+0x2a/0x2a [] ? nfs_callback_up+0x548/0x548 [nfsv4] [] kthread+0xb5/0xbd [] ? kthread_freezable_should_stop+0x65/0x65 [] ret_from_fork+0x7c/0xb0 [] ? kthread_freezable_should_stop+0x65/0x65 I read such threads [1] nfs/sunrpc: allow freezing of tasks with NFS calls in flight [2] LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held! and then modify nfs41_callback_svc(). It works on my machine. I don't know the details of freezing, so I'm not sure if the modification is reasonable. This is not a formal patch. Thanks. Signed-off-by: Yanchuan Nian --- fs/nfs/callback.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c index 5088b57..8addb7b 100644 --- a/fs/nfs/callback.c +++ b/fs/nfs/callback.c @@ -138,7 +138,7 @@ nfs41_callback_svc(void *vrqstp) error); } else { spin_unlock_bh(&serv->sv_cb_lock); - schedule(); + freezable_schedule(); } finish_wait(&serv->sv_cb_waitq, &wq); }