| Message ID | 1364839315.21627.69.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 2013-04-01 at 20:01 +0200, Paul Bolle wrote: > nfs4.h exports "u64" to userspace. Use "__u64" instead. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > 0) Tested with a kernel build. > > 1) I'm guessing userspace doesn't actually use NFS4_MAX_UINT64. > > include/uapi/linux/nfs4.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/nfs4.h b/include/uapi/linux/nfs4.h > index 788128e..35f5f4c 100644 > --- a/include/uapi/linux/nfs4.h > +++ b/include/uapi/linux/nfs4.h > @@ -150,7 +150,7 @@ > #define NFS4_SECINFO_STYLE4_CURRENT_FH 0 > #define NFS4_SECINFO_STYLE4_PARENT 1 > > -#define NFS4_MAX_UINT64 (~(u64)0) > +#define NFS4_MAX_UINT64 (~(__u64)0) > > /* An NFS4 sessions server must support at least NFS4_MAX_OPS operations. > * If a compound requires more operations, adjust NFS4_MAX_OPS accordingly. Please just move it into include/linux/nfs4.h. As you said above, there is no reason to export this to userland at all. Thanks Trond
diff --git a/include/uapi/linux/nfs4.h b/include/uapi/linux/nfs4.h index 788128e..35f5f4c 100644 --- a/include/uapi/linux/nfs4.h +++ b/include/uapi/linux/nfs4.h @@ -150,7 +150,7 @@ #define NFS4_SECINFO_STYLE4_CURRENT_FH 0 #define NFS4_SECINFO_STYLE4_PARENT 1 -#define NFS4_MAX_UINT64 (~(u64)0) +#define NFS4_MAX_UINT64 (~(__u64)0) /* An NFS4 sessions server must support at least NFS4_MAX_OPS operations. * If a compound requires more operations, adjust NFS4_MAX_OPS accordingly.
nfs4.h exports "u64" to userspace. Use "__u64" instead. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Tested with a kernel build. 1) I'm guessing userspace doesn't actually use NFS4_MAX_UINT64. include/uapi/linux/nfs4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)