diff mbox

[1/5] NFSv4: Remove redundant check for FMODE_EXEC in nfs_finish_open

Message ID 1369857925-42068-1-git-send-email-Trond.Myklebust@netapp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Trond Myklebust May 29, 2013, 8:05 p.m. UTC
We already check the EXEC access mode in the lower layers.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---
 fs/nfs/dir.c | 7 -------
 1 file changed, 7 deletions(-)
diff mbox

Patch

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index e093e73..bf4e5f4 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -1362,13 +1362,6 @@  static int nfs_finish_open(struct nfs_open_context *ctx,
 		ctx->dentry = dget(dentry);
 	}
 
-	/* If the open_intent is for execute, we have an extra check to make */
-	if (ctx->mode & FMODE_EXEC) {
-		err = nfs_may_open(dentry->d_inode, ctx->cred, open_flags);
-		if (err < 0)
-			goto out;
-	}
-
 	err = finish_open(file, dentry, do_open, opened);
 	if (err)
 		goto out;