| Message ID | 1372185454-1888-2-git-send-email-andros@netapp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2013-06-25 at 14:37 -0400, andros@netapp.com wrote: > From: Andy Adamson <andros@netapp.com> > > nfs4_init_session is called after CREATE_SESSION has set the ca_maxrequestsize > and ca_maxresponsesize values obtained from the server. It had better not be, otherwise the values of session->fc_target_max_rqst_sz and session->fc_target_max_resp_sz in nfs4_init_channel_attrs() make no sense.
On Jun 25, 2013, at 2:52 PM, "Myklebust, Trond" <Trond.Myklebust@netapp.com> wrote: > On Tue, 2013-06-25 at 14:37 -0400, andros@netapp.com wrote: >> From: Andy Adamson <andros@netapp.com> >> >> nfs4_init_session is called after CREATE_SESSION has set the ca_maxrequestsize >> and ca_maxresponsesize values obtained from the server. > > It had better not be, otherwise the values of > session->fc_target_max_rqst_sz and session->fc_target_max_resp_sz in > nfs4_init_channel_attrs() make no sense. Well, it does. Shall I move the nfs4_init_session call to before nfs4_init_channel_attrs? added dprintk and did a mount: --> nfs41_init_clientid --> nfs4_proc_create_session clp=ffff88005ff67800 session=ffff88005ff66c00 nfs4_init_channel_attrs: Fore Channel : max_rqst_sz=1048576 max_resp_sz=1048576 max_ops=8 max_reqs=16 nfs4_init_channel_attrs: BackChannel : max_rqst_sz=4096 max_resp_sz=4096 max_resp_sz_cached=0 max_ops=2 max_reqs=1 # ANDROS: set by server HERE decode_chan_attrs max_resp_sz 81920 decode_chan_attrs max_resp_sz 4096 --> nfs4_verify_fore_channel_attrs rcvd->max_resp_sz 81920 --> nfs4_setup_session_slot_tables --> nfs4_realloc_slot_table: max_reqs=16, tbl->max_slots 0 nfs4_realloc_slot_table: tbl=ffff88005ff66c40 slots=ffff88007a5edbc0 max_slots=16 <-- nfs4_realloc_slot_table: return 0 --> nfs4_realloc_slot_table: max_reqs=1, tbl->max_slots 0 nfs4_realloc_slot_table: tbl=ffff88005ff66e08 slots=ffff88007a5ed640 max_slots=1 <-- nfs4_realloc_slot_table: return 0 slot table setup returned 0 nfs4_proc_create_session client>seqid 2 sessionid 150994944:4550600:0:100925440 <-- nfs4_proc_create_session nfs4_schedule_state_renewal: requeueing work. Lease period = 5 # ANDROS: Still correct when NFS4_CLNT_READY set: <-- nfs41_init_clientid clp->cl_session->fc_attrs->mas_resp_sz 81920 Invoking bc_svc_process() # ANDROS: Using session for RECLAIM COMPLETE --> nfs41_proc_reclaim_complete --> nfs41_setup_sequence --> nfs4_alloc_slot used_slots=0000 highest_used=4294967295 max_slots=16 <-- nfs4_alloc_slot used_slots=0001 highest_used=0 slotid=0 <-- nfs41_setup_sequence slotid=0 seqid=1 encode_sequence: sessionid=150994944:4550600:0:100925440 seqid=1 slotid=0 max_slotid=0 cache_this=0 bc_svc_process() returned w/ error code= 0 --> nfs4_reclaim_complete_done --> nfs4_alloc_slot used_slots=0001 highest_used=0 max_slots=1 <-- nfs4_alloc_slot used_slots=0001 highest_used=0 slotid=-1 nfs41_sequence_done: Error 0 free the slot nfs4_free_slot: slotid 0 highest_used_slotid -1 <-- nfs4_reclaim_complete_done --> nfs_put_client({3}) --> nfs4_match_clientids client ID c86f450000000009 matches c86f450000000009 NFS: --> nfs4_match_serverowners server owners match NFS: <-- nfs41_walk_client_list using nfs_client = ffff88005ff67800 ({3}) NFS: <-- nfs41_walk_client_list status = 0 --> nfs_put_client({3}) NFS: nfs4_discover_server_trunking: status = 0 --> nfs_put_client({2}) <-- nfs4_set_client() = 0 [new ffff88005ff67800] <-- nfs4_init_server() = 0 #ANDROS: after using the session, Now we init it???? --> nfs4_init_session nfs4_init_session taking cl_lock nfs4_init_session test and clear case #ANDROS - BUG - reset the max_resp_sz!! <-- nfs4_init_session session->fc_attrs.max_resp_sz 1049480 > -- > Trond Myklebust > Linux NFS client maintainer > > NetApp > Trond.Myklebust@netapp.com > www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2013-06-25 at 19:05 +0000, Adamson, Andy wrote: > On Jun 25, 2013, at 2:52 PM, "Myklebust, Trond" <Trond.Myklebust@netapp.com> > wrote: > > > On Tue, 2013-06-25 at 14:37 -0400, andros@netapp.com wrote: > >> From: Andy Adamson <andros@netapp.com> > >> > >> nfs4_init_session is called after CREATE_SESSION has set the ca_maxrequestsize > >> and ca_maxresponsesize values obtained from the server. > > > > It had better not be, otherwise the values of > > session->fc_target_max_rqst_sz and session->fc_target_max_resp_sz in > > nfs4_init_channel_attrs() make no sense. > > Well, it does. Shall I move the nfs4_init_session call to before nfs4_init_channel_attrs? > Either that, or change nfs4_init_channel_attrs() to always use NFS_MAX_FILE_IO_SIZE. Right now, the code is just confused (and very confusing).
diff --git a/fs/nfs/nfs4session.c b/fs/nfs/nfs4session.c index c4e225e..7ac14cc 100644 --- a/fs/nfs/nfs4session.c +++ b/fs/nfs/nfs4session.c @@ -499,13 +499,11 @@ int nfs4_init_session(struct nfs_server *server) session = clp->cl_session; spin_lock(&clp->cl_lock); if (test_and_clear_bit(NFS4_SESSION_INITING, &session->session_state)) { - /* Initialise targets and channel attributes */ + /* Initialise targets */ session->fc_target_max_rqst_sz = target_max_rqst_sz; - session->fc_attrs.max_rqst_sz = target_max_rqst_sz; session->fc_target_max_resp_sz = target_max_resp_sz; - session->fc_attrs.max_resp_sz = target_max_resp_sz; } else { - /* Just adjust the targets */ + /* Adjust the targets and perhaps reset the session */ if (target_max_rqst_sz > session->fc_target_max_rqst_sz) { session->fc_target_max_rqst_sz = target_max_rqst_sz; set_bit(NFS4CLNT_SESSION_RESET, &clp->cl_state);