Message ID | 1378482230-16312-1-git-send-email-bfields@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, Sep 06, 2013 at 11:43:48AM -0400, J. Bruce Fields wrote: > diff --git a/fs/dcache.c b/fs/dcache.c > index b949af8..934f02d 100644 > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -393,7 +393,7 @@ static void __d_shrink(struct dentry *dentry) > { > if (!d_unhashed(dentry)) { > struct hlist_bl_head *b; > - if (unlikely(dentry->d_flags & DCACHE_DISCONNECTED)) > + if (unlikely(IS_ROOT(dentry))) I think this needs a comment about why the IS_ROOT check is fine, destilled from your commit log. Also while reviewing this I noticed that one of the two callers of __d_shrink already has the d_unhashed check - it might make sense to move it to the other caller as well if you touch this area anyway. (as a separate patch). -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/dcache.c b/fs/dcache.c index b949af8..934f02d 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -393,7 +393,7 @@ static void __d_shrink(struct dentry *dentry) { if (!d_unhashed(dentry)) { struct hlist_bl_head *b; - if (unlikely(dentry->d_flags & DCACHE_DISCONNECTED)) + if (unlikely(IS_ROOT(dentry))) b = &dentry->d_sb->s_anon; else b = d_hash(dentry->d_parent, dentry->d_name.hash);