diff mbox

[v2] nfs: Use PTR_ERR_OR_ZERO in 'nfs41_callback_up' function

Message ID 1381782256-2434-1-git-send-email-geyslan@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Geyslan G. Bem Oct. 14, 2013, 8:24 p.m. UTC
Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'.

Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
 fs/nfs/callback.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Geyslan G. Bem Oct. 14, 2013, 8:32 p.m. UTC | #1
2013/10/14 Geyslan G. Bem <geyslan@gmail.com>:
> Use 'PTR_ERR_OR_ZERO()' rather than 'IS_ERR(...) ? PTR_ERR(...) : 0'.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
>  fs/nfs/callback.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
> index 67cd732..073b4cf 100644
> --- a/fs/nfs/callback.c
> +++ b/fs/nfs/callback.c
> @@ -164,8 +164,7 @@ nfs41_callback_up(struct svc_serv *serv)
>                 svc_xprt_put(serv->sv_bc_xprt);
>                 serv->sv_bc_xprt = NULL;
>         }
> -       dprintk("--> %s return %ld\n", __func__,
> -               IS_ERR(rqstp) ? PTR_ERR(rqstp) : 0);
> +       dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp));
>         return rqstp;
>  }
>
> --
> 1.8.4
>
In this version (v2):
Format changed from %ld to %d.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
index 67cd732..073b4cf 100644
--- a/fs/nfs/callback.c
+++ b/fs/nfs/callback.c
@@ -164,8 +164,7 @@  nfs41_callback_up(struct svc_serv *serv)
 		svc_xprt_put(serv->sv_bc_xprt);
 		serv->sv_bc_xprt = NULL;
 	}
-	dprintk("--> %s return %ld\n", __func__,
-		IS_ERR(rqstp) ? PTR_ERR(rqstp) : 0);
+	dprintk("--> %s return %d\n", __func__, PTR_ERR_OR_ZERO(rqstp));
 	return rqstp;
 }