From patchwork Thu Nov 7 15:47:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 3153331 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AD280BEEB2 for ; Thu, 7 Nov 2013 15:47:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 935982041B for ; Thu, 7 Nov 2013 15:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DE6920412 for ; Thu, 7 Nov 2013 15:47:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751701Ab3KGPrk (ORCPT ); Thu, 7 Nov 2013 10:47:40 -0500 Received: from mail-qe0-f42.google.com ([209.85.128.42]:64153 "EHLO mail-qe0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258Ab3KGPrj (ORCPT ); Thu, 7 Nov 2013 10:47:39 -0500 Received: by mail-qe0-f42.google.com with SMTP id gc15so629948qeb.1 for ; Thu, 07 Nov 2013 07:47:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=QrzUEqeIOLkyg8zsskMu7bXgm8/1Buo3n+6yl6m0+uQ=; b=NUeQZAfBwSRxgwdwG6Gu+45rHrwycosryZ3Pm2+CAL6xqxlcy0FvyosDKy1i/90tY6 CoGCvwRE5AaHa7iFbxeFVwMSPsU6nJUTvrbRpUH3euMg6m+OAUCrHrSg9ec6kDaTLEcB 6x/WPQPZWNDDCUDUlG2vhENuF4ffYqNOirrQ4TtURzHCDeE9Dib6+0LOvWVBb3w7rsQ/ 1wqOXZHtAT+BafdmeHMrvndsnpBsIZmGiTb3XjicEoGEF1UAJBYlHLjwtwm0+m5knD2X nFXn0L5klb89v+nW6iHRt6mJ5YOJq6efo2HGk7l1bdMX4Ml/QGJIBGMELVf94rklWY93 p7Yg== X-Gm-Message-State: ALoCoQltc4uK0mVz201td16xQHE1rzGREW7ix9Nn1wcbKTVjiAUN9zaQRzfwzJq2G0zsiWOxPcEL X-Received: by 10.49.24.202 with SMTP id w10mr14348110qef.12.1383839258404; Thu, 07 Nov 2013 07:47:38 -0800 (PST) Received: from salusa.poochiereds.net (cpe-107-015-124-230.nc.res.rr.com. [107.15.124.230]) by mx.google.com with ESMTPSA id r5sm8738753qeh.1.2013.11.07.07.47.37 for (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Thu, 07 Nov 2013 07:47:37 -0800 (PST) From: Jeff Layton To: steved@redhat.com Cc: linux-nfs@vger.kernel.org Subject: [PATCH] gssd: cut down log chatter in gssd_search_krb5_keytab Date: Thu, 7 Nov 2013 10:47:33 -0500 Message-Id: <1383839253-8223-1-git-send-email-jlayton@redhat.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Because the kernel now looks for krb5 creds by default when mounting, we need to always have clients run rpc.gssd to avoid the 15s hang on the first mount attempt. In situations however where people don't have krb5 set up, this leads to a lot of log spamming on mount attempts. Try to cut down on some of the log chatter by lowering the priority of the log messages in gssd_search_krb5_keytab(). Signed-off-by: Jeff Layton --- utils/gssd/krb5_util.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c index 697d1d2..2ca3adc 100644 --- a/utils/gssd/krb5_util.c +++ b/utils/gssd/krb5_util.c @@ -711,13 +711,13 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt, */ if ((code = krb5_kt_get_name(context, kt, kt_name, BUFSIZ))) { k5err = gssd_k5_err_msg(context, code); - printerr(0, "ERROR: %s attempting to get keytab name\n", k5err); + printerr(1, "ERROR: %s attempting to get keytab name\n", k5err); retval = code; goto out; } if ((code = krb5_kt_start_seq_get(context, kt, &cursor))) { k5err = gssd_k5_err_msg(context, code); - printerr(0, "ERROR: %s while beginning keytab scan " + printerr(1, "ERROR: %s while beginning keytab scan " "for keytab '%s'\n", k5err, kt_name); retval = code; goto out; @@ -727,7 +727,7 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt, if ((code = krb5_unparse_name(context, kte->principal, &pname))) { k5err = gssd_k5_err_msg(context, code); - printerr(0, "WARNING: Skipping keytab entry because " + printerr(1, "WARNING: Skipping keytab entry because " "we failed to unparse principal name: %s\n", k5err); k5_free_kt_entry(context, kte); @@ -768,7 +768,7 @@ gssd_search_krb5_keytab(krb5_context context, krb5_keytab kt, if ((code = krb5_kt_end_seq_get(context, kt, &cursor))) { k5err = gssd_k5_err_msg(context, code); - printerr(0, "WARNING: %s while ending keytab scan for " + printerr(1, "WARNING: %s while ending keytab scan for " "keytab '%s'\n", k5err, kt_name); }