From patchwork Tue Dec 31 19:39:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 3422531 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 91177C02DC for ; Tue, 31 Dec 2013 19:40:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B60F320120 for ; Tue, 31 Dec 2013 19:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA6F72011E for ; Tue, 31 Dec 2013 19:40:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756510Ab3LaTkE (ORCPT ); Tue, 31 Dec 2013 14:40:04 -0500 Received: from mail-ie0-f181.google.com ([209.85.223.181]:57622 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756407Ab3LaTkD (ORCPT ); Tue, 31 Dec 2013 14:40:03 -0500 Received: by mail-ie0-f181.google.com with SMTP id e14so13503665iej.12 for ; Tue, 31 Dec 2013 11:40:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AZVu5NL5GDbkx6NmHUH3QS0phnsaZpG5Iy10VNKfBMs=; b=GGXpS9m3fcoSSWE+f5yFDejaGM/ri+XRu0XGzMewDO3Hy0j53UlRLeVDrUru7/Ni4P WMQrE3ZcCEoiYDBKaIWmIAHgoGhQNegrSlbqOfWeu1XTEmY5eQCnxcZWTBucxEzfyoF6 v3Zf85Q7nB+JqMhqnlbI0Len2GnYrAe6t4BGKdTX4OWysu5SrGEU+XUWGvdAB8V2lDnT WvT/aV0hiYkHIfO2o/48hje22SsNFAlW2M8wgUZqWoWvJLI0ZVpklJSgGbc2hCMFTLKj Es7sbFzTt+MNAGFdVKTwEPJEDepLdGbCyIMKw5hIOc/WjYKFwK8KIaNZzbS8zM/WdQob uT5Q== X-Gm-Message-State: ALoCoQnNAAJ48Pf107jBWDvHSy0y8LqR9KIHJg0r9BAM6XSghTZRddWdTmizQsZhL+BbRFnGqRQF X-Received: by 10.43.51.65 with SMTP id vh1mr52216376icb.24.1388518800690; Tue, 31 Dec 2013 11:40:00 -0800 (PST) Received: from leira.trondhjem.org (c-98-209-19-95.hsd1.mi.comcast.net. [98.209.19.95]) by mx.google.com with ESMTPSA id t4sm65910073igm.10.2013.12.31.11.39.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Dec 2013 11:39:59 -0800 (PST) From: Trond Myklebust To: linux-nfs@vger.kernel.org Cc: Kinglong Mee , Chuck Lever , Bruce Fields , Gareth Williams Subject: [PATCH 1/4] SUNRPC: Ensure xprt_connect_status handles all potential connection errors Date: Tue, 31 Dec 2013 14:39:38 -0500 Message-Id: <1388518781-33571-1-git-send-email-trond.myklebust@primarydata.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: References: Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, xprt_connect_status will convert connection error values such as ECONNREFUSED, ECONNRESET, ... into EIO, which means that they never get handled. Signed-off-by: Trond Myklebust --- net/sunrpc/xprt.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c index 04199bc8416f..ddd198e90292 100644 --- a/net/sunrpc/xprt.c +++ b/net/sunrpc/xprt.c @@ -749,6 +749,11 @@ static void xprt_connect_status(struct rpc_task *task) } switch (task->tk_status) { + case -ECONNREFUSED: + case -ECONNRESET: + case -ECONNABORTED: + case -ENETUNREACH: + case -EHOSTUNREACH: case -EAGAIN: dprintk("RPC: %5u xprt_connect_status: retrying\n", task->tk_pid); break;