From patchwork Mon Jan 20 10:07:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shaobingqing X-Patchwork-Id: 3511361 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 137B4C02DC for ; Mon, 20 Jan 2014 10:12:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B45382015A for ; Mon, 20 Jan 2014 10:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 291D620148 for ; Mon, 20 Jan 2014 10:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbaATKMQ (ORCPT ); Mon, 20 Jan 2014 05:12:16 -0500 Received: from mx.bwstor.com.cn ([211.103.180.228]:36666 "EHLO mx.bwstor.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750917AbaATKMP (ORCPT ); Mon, 20 Jan 2014 05:12:15 -0500 Received: from localhost (localhost [127.0.0.1]) by mx.bwstor.cn (Postfix) with ESMTP id 6985865BD1; Mon, 20 Jan 2014 18:12:03 +0800 (CST) Received: from mx.bwstor.cn ([127.0.0.1]) by localhost (mx1.bwstor.com.cn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ywEPO78Sd_RS; Mon, 20 Jan 2014 18:12:03 +0800 (CST) Received: from linux-odmv.site (unknown [10.10.37.58]) by mx.bwstor.cn (Postfix) with ESMTPA id 3C4C965BBF; Mon, 20 Jan 2014 18:12:03 +0800 (CST) From: shaobingqing To: trond.myklebust@primarydata.com Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, shaobingqing Subject: [PATCH] NFSv4.1: PNFS_BLOCK_NONE_DATA should be handle properly in bl_add_merge_extent? Date: Mon, 20 Jan 2014 18:07:28 +0800 Message-Id: <1390212448-21354-1-git-send-email-shaobingqing@bwstor.com.cn> X-Mailer: git-send-email 1.7.4.2 In-Reply-To: References: Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In the current code, extents would not delete from the bl_extents list when lseg is removed from layout. Now one extent's lseg is deleted and its type is PNFS_BLOCK_NONE_DATA, while a layoutget request get a extent with the same range and its type is PNFS_BLOCK_NONE_DATA. In this situation the function bl_add_merge_extent will return -EIO. Furthermore, the READ op which request the layout will be execute in band. This perhaps not only degrade performance, but also result in data unconsistency. Signed-off-by: shaobingqing --- fs/nfs/blocklayout/extents.c | 50 ++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/fs/nfs/blocklayout/extents.c b/fs/nfs/blocklayout/extents.c index 9c3e117..7472b38 100644 --- a/fs/nfs/blocklayout/extents.c +++ b/fs/nfs/blocklayout/extents.c @@ -518,6 +518,34 @@ bl_add_merge_extent(struct pnfs_block_layout *bl, __func__); bl_put_extent(new); return 0; + } else if (be->be_state == + PNFS_BLOCK_NONE_DATA) { + splice = bl_alloc_extent(); + if (!splice) { + bl_put_extent(new); + return -ENOMEM; + } + memcpy(splice, be, + sizeof(struct pnfs_block_extent)); + splice->be_f_offset = end; + splice->be_length = be->be_f_offset + + be->be_length - end; + be->be_length = new->be_f_offset + - be->be_f_offset; + splice->be_v_offset = 0; + + list_add(&new->be_node, &be->be_node); + if (be->be_length == 0) { + list_del(&be->be_node); + bl_put_extent(be); + } + if (splice->be_length != 0) + list_add(&splice->be_node, + &new->be_node); + else + bl_put_extent(splice); + + return 0; } else { goto out_err; } @@ -533,6 +561,13 @@ bl_add_merge_extent(struct pnfs_block_layout *bl, dprintk("%s: removing %p\n", __func__, be); list_del(&be->be_node); bl_put_extent(be); + } else if (be->be_state == PNFS_BLOCK_NONE_DATA) { + be->be_length = new->be_f_offset + - be->be_f_offset; + if (be->be_length == 0) { + list_del(&be->be_node); + bl_put_extent(be); + } } else { goto out_err; } @@ -544,6 +579,10 @@ bl_add_merge_extent(struct pnfs_block_layout *bl, dprintk("%s: removing %p\n", __func__, be); list_del(&be->be_node); bl_put_extent(be); + + } else if (be->be_state == PNFS_BLOCK_NONE_DATA) { + list_del(&be->be_node); + bl_put_extent(be); } else { goto out_err; } @@ -557,6 +596,17 @@ bl_add_merge_extent(struct pnfs_block_layout *bl, dprintk("%s: removing %p\n", __func__, be); list_del(&be->be_node); bl_put_extent(be); + + } else if (be->be_state == PNFS_BLOCK_NONE_DATA) { + be->be_length -= end - be->be_f_offset; + be->be_v_offset += end - be->be_f_offset; + be->be_f_offset = end; + list_add(&new->be_node, be->be_node.prev); + if (be->be_length == 0) { + list_del(&be->be_node); + bl_put_extent(be); + } + return 0; } else { goto out_err; }