From patchwork Wed Feb 26 19:29:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 3727941 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 66DFB9F2F7 for ; Wed, 26 Feb 2014 19:30:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5E27F201BA for ; Wed, 26 Feb 2014 19:30:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5900920127 for ; Wed, 26 Feb 2014 19:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347AbaBZTaU (ORCPT ); Wed, 26 Feb 2014 14:30:20 -0500 Received: from mail-pd0-f174.google.com ([209.85.192.174]:63780 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbaBZT3x (ORCPT ); Wed, 26 Feb 2014 14:29:53 -0500 Received: by mail-pd0-f174.google.com with SMTP id y13so1348106pdi.19 for ; Wed, 26 Feb 2014 11:29:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:content-type:mime-version :content-transfer-encoding; bh=Qw517B6WJT+RY6Nfb8HfoS/AkO3FJmh3dMDPL5PqE8M=; b=m8jr1mQAwoPyn3A0Kfny9jNGNlCav12Q5e72I4x/8/FDpGOcvgIxsVF4G8rRqRLsv3 4WLfEBIrTzMJYSSbhz0y38f+6pQTEtVxpuQn3VdflGClxBGsqdHX/MMbsyC/CneJzD1B FlvUiojS2Dm/8fIPEZy2/9oUvrmgK8lIKFJmTpjFr80iwL0LlDEXrI46HcUSECDPfiLT //tAEhy+cJ9ma8Nsg6rsOBRzflBmwXxcXL9AGiH6ZgeAGdIOHy46q/rAPhp4W1h9rWBF tGzYySN2PfRUCjtXmD0Yh1snv5uxT2w+rplUxFhqWiIiIJX4OG0iNkcE7KeGf+OdVDAV OiuQ== X-Gm-Message-State: ALoCoQnlY6aA2mgDq4XO0emmBAxfWDQnIJSLjyrR03Obhy6+mZx5BOlN99vbXmIAQ+kP/47iBn9k X-Received: by 10.68.189.198 with SMTP id gk6mr8822859pbc.146.1393442992573; Wed, 26 Feb 2014 11:29:52 -0800 (PST) Received: from [172.16.74.153] (64-13-12-30.eug.clearwire-dns.net. [64.13.12.30]) by mx.google.com with ESMTPSA id yg4sm13188735pab.19.2014.02.26.11.29.50 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 26 Feb 2014 11:29:51 -0800 (PST) Message-ID: <1393442989.5090.4.camel@leira.trondhjem.org> Subject: Re: Oops in nfs41_assign_slot in Linux 3.13.4 From: Trond Myklebust To: Ben Hutchings Cc: 734268@bugs.debian.org, Arthur de Jong , linux-nfs@vger.kernel.org Date: Wed, 26 Feb 2014 11:29:49 -0800 In-Reply-To: <1393376280.14067.34.camel@deadeye.wl.decadent.org.uk> References: <1388922864.10916.7.camel@sorbet.thuis.net> <1393361101.5000.26.camel@sorbet.thuis.net> <1393376280.14067.34.camel@deadeye.wl.decadent.org.uk> Organization: PrimaryData Inc X-Mailer: Evolution 3.10.4 (3.10.4-1.fc20) Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Ben, On Wed, 2014-02-26 at 00:58 +0000, Ben Hutchings wrote: > Trond, Arthur seems to be hitting a similar bug to > , and it's still > occurring in 3.13.4 even though that has the two fixes you posted there. > The full bug report, with screenshots of the oopses, is at > . > I believe I've found another corruptor of that same list. Do Arthur's tests perhaps touch on file locking? If so, then the following patch may help... Cheers Trond 8<---------------------------------------------------------------------- From 3db0ebd8e7e67d9ee96f623e7d1dcdc35fccea7f Mon Sep 17 00:00:00 2001 From: Trond Myklebust Date: Wed, 26 Feb 2014 11:19:14 -0800 Subject: [PATCH] NFSv4: Fix another nfs4_sequence corruptor nfs4_release_lockowner needs to set the rpc_message reply to point to the nfs4_sequence_res in order to avoid another Oopsable situation in nfs41_assign_slot. Fixes: fbd4bfd1d9d21 (NFS: Add nfs4_sequence calls for RELEASE_LOCKOWNER) Cc: stable@vger.kernel.org # 3.12+ Signed-off-by: Trond Myklebust --- fs/nfs/nfs4proc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 2da6a698b8f7..d3b829f7c509 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -5895,6 +5895,7 @@ static int nfs4_release_lockowner(struct nfs_server *server, struct nfs4_lock_st data->args.lock_owner.s_dev = server->s_dev; msg.rpc_argp = &data->args; + msg.rpc_resp = &data->res; rpc_call_async(server->client, &msg, 0, &nfs4_release_lockowner_ops, data); return 0; }