From patchwork Thu May 29 15:07:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 4265701 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0135ABEEA7 for ; Thu, 29 May 2014 15:07:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 03F9820351 for ; Thu, 29 May 2014 15:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCF3B20149 for ; Thu, 29 May 2014 15:07:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757335AbaE2PHG (ORCPT ); Thu, 29 May 2014 11:07:06 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:50706 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756246AbaE2PHF (ORCPT ); Thu, 29 May 2014 11:07:05 -0400 Received: by mail-ie0-f173.google.com with SMTP id lx4so410803iec.32 for ; Thu, 29 May 2014 08:07:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:content-type:mime-version :content-transfer-encoding; bh=rzvyOsQmSiVRy0j3Y5GE1DNE+EKA7COkfXq0izIlz34=; b=ccLDqGr+SpWhht0JxVS9Ht2VK/BCIq10gtFRn25HXQbZ52NTWXYguLrvSg7K+3tYVQ nXpP5JT32HfskWWS+A20yLv6m9fUjdorUQ67XnA/pQlFCNeirefkoczywq9mQkSVQdug 8c1umrIB5S+9Shje5EKP3eJrjRhxOR9TuHgdzsY2lN1zd3Aj1mIY/bNw3P+alsIDYWF0 JRmRLkZAGsQcL6ZCQSXifGHKivPkGaXaoyd6mQykCBkfqbff7P2SoOmGR447Hb4BHRyG kRHBu5phCqzvA4fSy0fWTiUrey8YqAnHdHg4dsLkRLcDlpsRlnHvos65SS4c0KWvaKDo WZfA== X-Gm-Message-State: ALoCoQmp5fe3yKv4qBG6GFGZx1ZhLTBi1Msd4W2SxMbzwwfBoWnOd7cnkjtkASNxwOfBhWmO9B0l X-Received: by 10.50.138.72 with SMTP id qo8mr11374559igb.26.1401376024675; Thu, 29 May 2014 08:07:04 -0700 (PDT) Received: from [172.16.74.153] (c-98-209-19-95.hsd1.mi.comcast.net. [98.209.19.95]) by mx.google.com with ESMTPSA id hy3sm6073437igb.1.2014.05.29.08.07.03 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 29 May 2014 08:07:04 -0700 (PDT) Message-ID: <1401376022.6543.3.camel@leira.trondhjem.org> Subject: Re: [nfs:devel 21/48] fs/nfs/pagelist.c:453: warning: unused variable 'inode' From: Trond Myklebust To: Anna Schumaker Cc: Linux NFS Mailing List Date: Thu, 29 May 2014 11:07:02 -0400 In-Reply-To: <538676fe.74/Y9ZfdJIRe5CAC%fengguang.wu@intel.com> References: <538676fe.74/Y9ZfdJIRe5CAC%fengguang.wu@intel.com> Organization: PrimaryData Inc X-Mailer: Evolution 3.10.4 (3.10.4-2.fc20) Mime-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 2014-05-29 at 07:53 +0800, kbuild test robot wrote: > tree: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git devel > head: c75c3b0bfffdb21daecb7dadbd30eb2e353fe66d > commit: 5aea6ba186d825973a1c3daf88dece597b8b54e3 [21/48] NFS: Create a common initiate_pgio() function > config: make ARCH=avr32 atngw100_defconfig > > All warnings: > > fs/nfs/pagelist.c: In function 'nfs_initiate_pgio': > >> fs/nfs/pagelist.c:453: warning: unused variable 'inode' > > vim +/inode +453 fs/nfs/pagelist.c > > 437 * nfs_pgio_prepare - Prepare pageio data to go over the wire > 438 * @task: The current task > 439 * @calldata: pageio data to prepare > 440 */ > 441 static void nfs_pgio_prepare(struct rpc_task *task, void *calldata) > 442 { > 443 struct nfs_pgio_data *data = calldata; > 444 int err; > 445 err = NFS_PROTO(data->header->inode)->pgio_rpc_prepare(task, data); > 446 if (err) > 447 rpc_exit(task, err); > 448 } > 449 > 450 int nfs_initiate_pgio(struct rpc_clnt *clnt, struct nfs_pgio_data *data, > 451 const struct rpc_call_ops *call_ops, int how, int flags) > 452 { > > 453 struct inode *inode = data->header->inode; > 454 struct rpc_task *task; > 455 struct rpc_message msg = { > 456 .rpc_argp = &data->args, > 457 .rpc_resp = &data->res, > 458 .rpc_cred = data->header->cred, > 459 }; > 460 struct rpc_task_setup task_setup_data = { > 461 .rpc_client = clnt, > > --- > 0-DAY kernel build testing backend Open Source Technology Center > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation Fixing this up using: From 86e52bd318d0fda06c6c9829ec54f693bd669b30 Mon Sep 17 00:00:00 2001 From: Trond Myklebust Date: Thu, 29 May 2014 11:04:51 -0400 Subject: [PATCH] fixup! NFS: Create a common initiate_pgio() function --- fs/nfs/pagelist.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c index 0c4aac4c7ad9..fab78d13ee14 100644 --- a/fs/nfs/pagelist.c +++ b/fs/nfs/pagelist.c @@ -604,7 +604,6 @@ static void nfs_pgio_prepare(struct rpc_task *task, void *calldata) int nfs_initiate_pgio(struct rpc_clnt *clnt, struct nfs_pgio_data *data, const struct rpc_call_ops *call_ops, int how, int flags) { - struct inode *inode = data->header->inode; struct rpc_task *task; struct rpc_message msg = { .rpc_argp = &data->args, @@ -627,8 +626,8 @@ int nfs_initiate_pgio(struct rpc_clnt *clnt, struct nfs_pgio_data *data, dprintk("NFS: %5u initiated pgio call " "(req %s/%llu, %u bytes @ offset %llu)\n", data->task.tk_pid, - inode->i_sb->s_id, - (unsigned long long)NFS_FILEID(inode), + data->header->inode->i_sb->s_id, + (unsigned long long)NFS_FILEID(data->header->inode), data->args.count, (unsigned long long)data->args.offset);