From patchwork Wed Jun 4 22:36:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Haynes X-Patchwork-Id: 4297481 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 97B469F326 for ; Wed, 4 Jun 2014 22:36:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DCF082010E for ; Wed, 4 Jun 2014 22:36:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7EE120107 for ; Wed, 4 Jun 2014 22:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbaFDWgT (ORCPT ); Wed, 4 Jun 2014 18:36:19 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:58467 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbaFDWgT (ORCPT ); Wed, 4 Jun 2014 18:36:19 -0400 Received: by mail-pd0-f181.google.com with SMTP id z10so140508pdj.26 for ; Wed, 04 Jun 2014 15:36:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1dss3Pi0lWSoxM8bcqdkRZyxzMvZJGhilUanoVq2utw=; b=Ov2VjnSOrSIKoaI5MpBgOcLZrCBSEPv/iEVrdl21zoxA2AVDvaT1EqMHSfuom5jXal 7B7tY0KmwDtqDS+peQon6A0LAsEI9ejPvLM1czo+CUY0JyUQao+aVKfpaYwogLT3VQWT owTrGK4NgPqIbgkh3x7C7tDNph4sGB8DBhAF1XhEkrshLmaob/O36mBh+hK4Gaxa8hSv MgejGyaZNDeOZHyCiAfyldYgUqeDo7RUJoryfZHoYfv/GbTJ4sjlNe1Odf15QTMgL6F3 ImxqDnl6huh85ty9Fpw7FeuumlmKucneOb5Cxm12e7Wz887L1ZF8CPka5wRRHWcai+qp MoyQ== X-Gm-Message-State: ALoCoQlFbKhYh4o4pqB2G3bvodIhH6OFKO+hxrscJhDoBOMkGlKi8oIbGoCI6Bwti/6gT9+Fx5rY X-Received: by 10.68.130.6 with SMTP id oa6mr1710683pbb.102.1401921378251; Wed, 04 Jun 2014 15:36:18 -0700 (PDT) Received: from localhost.localdomain ([50.242.95.105]) by mx.google.com with ESMTPSA id yw3sm14484735pbc.69.2014.06.04.15.36.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jun 2014 15:36:17 -0700 (PDT) From: Thomas Haynes X-Google-Original-From: Thomas Haynes To: trond.myklebust@primarydata.com, linux-nfs@vger.kernel.org Cc: Tom Haynes Subject: [PATCH] Comment is now wrong and redundant to code Date: Wed, 4 Jun 2014 15:36:05 -0700 Message-Id: <1401921365-22956-1-git-send-email-Thomas.Haynes@primarydata.com> X-Mailer: git-send-email 1.9.3 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tom Haynes The save of the write offset was removed some time ago, so that part of the comment is bogus. The remainder is pretty self-evident. So off with it! This is based off of trond/testing Signed-off-by: Tom Haynes --- fs/nfs/filelayout/filelayout.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filelayout.c index 7d479fd..b04ae035 100644 --- a/fs/nfs/filelayout/filelayout.c +++ b/fs/nfs/filelayout/filelayout.c @@ -608,10 +608,7 @@ filelayout_write_pagelist(struct nfs_pgio_data *data, int sync) fh = nfs4_fl_select_ds_fh(lseg, j); if (fh) data->args.fh = fh; - /* - * Get the file offset on the dserver. Set the write offset to - * this offset and save the original offset. - */ + data->args.offset = filelayout_get_dserver_offset(lseg, offset); /* Perform an asynchronous write */