From patchwork Thu Jan 22 23:36:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Haynes X-Patchwork-Id: 5689701 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E3D2DC058E for ; Thu, 22 Jan 2015 23:38:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3247820268 for ; Thu, 22 Jan 2015 23:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60465201B9 for ; Thu, 22 Jan 2015 23:38:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754594AbbAVXiL (ORCPT ); Thu, 22 Jan 2015 18:38:11 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:57642 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754432AbbAVXiK (ORCPT ); Thu, 22 Jan 2015 18:38:10 -0500 Received: by mail-pd0-f177.google.com with SMTP id y13so4598255pdi.8 for ; Thu, 22 Jan 2015 15:38:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2Vh5/7oC1Op7NYucu6Ochpy0OYzTsAKrz9otdKCFbMU=; b=deAIvnN9O1SiP+nppWgl7dMODJAvGoVbRMOujfg/bMNQFjVZ6dnxzjTtcvAmzPcUv4 iJ6pwyiKvr6zitMdLaKgt7MbVDL/hUGIerrYy2BeU0a70SmWQYLaYPVcnIYgKukMsko6 XTS10rJ0jMKAZSs2AKb2ePkK9w8BgoYEfq+m5KUod1CQo5r+Hyz8YBg+LrQ0HCtG30uA F4iUPPAlnKT/etrhQBNtwuIOkYCLjnE5FvV/g97HAeIFGrblMmSUag1Zi1eqK0iUY93k ICvG2kVtcJvL3tqbhw1JZCNaxmDDVHWC6mgHbXFmkEBEaWjTgkQ/pI8q15uvfnNtl/nY N8fA== X-Gm-Message-State: ALoCoQkIJ36M2f6Lnduic6qogxD/OKH/ZsR13RtFmSJtU+Wh6MYu2L0VfqlE6KHHe1Kltvj+0RhI X-Received: by 10.66.236.36 with SMTP id ur4mr6224282pac.107.1421969890302; Thu, 22 Jan 2015 15:38:10 -0800 (PST) Received: from localhost.localdomain ([50.242.95.105]) by mx.google.com with ESMTPSA id fu1sm366817pdb.80.2015.01.22.15.38.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2015 15:38:09 -0800 (PST) From: Tom Haynes X-Google-Original-From: Tom Haynes To: Trond Myklebust Cc: Linux NFS Mailing list Subject: [PATCH v5 38/51] nfs41: add a debug warning if we destroy an unempty layout Date: Thu, 22 Jan 2015 15:36:10 -0800 Message-Id: <1421969783-92997-39-git-send-email-loghyr@primarydata.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1421969783-92997-1-git-send-email-loghyr@primarydata.com> References: <1421969783-92997-1-git-send-email-loghyr@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Peng Tao So that we can detect the case if some layout segments are still pinned which is surely a bug that we need to fix. Signed-off-by: Peng Tao --- fs/nfs/pnfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c index 5f7c422..e123cfc 100644 --- a/fs/nfs/pnfs.c +++ b/fs/nfs/pnfs.c @@ -242,6 +242,8 @@ pnfs_put_layout_hdr(struct pnfs_layout_hdr *lo) struct inode *inode = lo->plh_inode; if (atomic_dec_and_lock(&lo->plh_refcount, &inode->i_lock)) { + if (!list_empty(&lo->plh_segs)) + WARN_ONCE(1, "NFS: BUG unfreed layout segments.\n"); pnfs_detach_layout_hdr(lo); spin_unlock(&inode->i_lock); pnfs_free_layout_hdr(lo);