From patchwork Mon Feb 9 03:07:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 5798081 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 88AABBF440 for ; Mon, 9 Feb 2015 03:07:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B734920211 for ; Mon, 9 Feb 2015 03:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DDDEB20221 for ; Mon, 9 Feb 2015 03:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759246AbbBIDHt (ORCPT ); Sun, 8 Feb 2015 22:07:49 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:42298 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759235AbbBIDHt (ORCPT ); Sun, 8 Feb 2015 22:07:49 -0500 Received: by iery20 with SMTP id y20so5074103ier.9 for ; Sun, 08 Feb 2015 19:07:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=/hly2gN9UVxquJ/YUEtaTH1AHNE9K8cmNp4L/4HA0mU=; b=IFdXrPn6hl0kKTivMBcFCVqrBmbjdGNQ80elZZg2LYhvn4HpHD7XVDY8PxzWj16jn3 h8wJgMR+zfq7xb7wW6wx1xBtb8wqaSoFCEJplQMtluaRUkCKfasViVbkvKhg+RN5OqrK GP9pgmhH28btR9aSCRgCBcbvnkpNTu14oNU0zaTXnSolRn/Ro908578ZialnGrlPu23U U4LeZbxSU64vHT35ib8acEJCVlgY0WuHd2taaggQViz/MwUcQV7eOdxAlugXEi5Ht2ys 1BXknhUx/lb4cBB7yfNH3UR9aA+FnVvp+tJx3PrQUEr59KNnP/OnWgWj8VQ2rOqpGbn8 XcJQ== X-Gm-Message-State: ALoCoQkrGdcaafoKkH1xoE2ztbhtiVrLU8dhLe368Cqe24Z1dLcp61e0b37cnW71f44aDEej68iT X-Received: by 10.50.1.48 with SMTP id 16mr14759312igj.45.1423451268678; Sun, 08 Feb 2015 19:07:48 -0800 (PST) Received: from leira.trondhjem.org.localdomain (c-68-40-185-14.hsd1.mi.comcast.net. [68.40.185.14]) by mx.google.com with ESMTPSA id w9sm1142240igl.0.2015.02.08.19.07.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Feb 2015 19:07:48 -0800 (PST) From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH 03/11] SUNRPC: Do not clear the source port in xs_reset_transport Date: Sun, 8 Feb 2015 22:07:34 -0500 Message-Id: <1423451262-84493-4-git-send-email-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1423451262-84493-3-git-send-email-trond.myklebust@primarydata.com> References: <1423451262-84493-1-git-send-email-trond.myklebust@primarydata.com> <1423451262-84493-2-git-send-email-trond.myklebust@primarydata.com> <1423451262-84493-3-git-send-email-trond.myklebust@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Now that we can reuse bound ports after a close, we never really want to clear the transport's source port after it has been set. Doing so really messes up the NFSv3 DRC on the server. Signed-off-by: Trond Myklebust --- net/sunrpc/xprtsock.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 20f25a837e06..ea1882f97912 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -811,8 +811,6 @@ static void xs_reset_transport(struct sock_xprt *transport) if (sk == NULL) return; - transport->srcport = 0; - write_lock_bh(&sk->sk_callback_lock); transport->inet = NULL; transport->sock = NULL;