From patchwork Fri Mar 27 16:52:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 6109671 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 285749F39E for ; Fri, 27 Mar 2015 16:53:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6003F203AD for ; Fri, 27 Mar 2015 16:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35C28203DA for ; Fri, 27 Mar 2015 16:53:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754114AbbC0Qwo (ORCPT ); Fri, 27 Mar 2015 12:52:44 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:34941 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754045AbbC0Qwk (ORCPT ); Fri, 27 Mar 2015 12:52:40 -0400 Received: by igcau2 with SMTP id au2so25601921igc.0 for ; Fri, 27 Mar 2015 09:52:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=y1HLcm64EwiDLaeCjC7vEKbaWd8OpReWwqwWAWghN5w=; b=Zn99T0vfGt1oJyWGkWjL8PzL40r9JvcexIi2ZBvnCn0ypcRMmiuCoi99jtK0IKXzvw ljiqAd6zW4E7gD5EKIjpu16IqtV2doye6jkaiOIYPlq9fJMej37CuGa18ORHCIywu5qP f96KtT8TaaQnKKkLEMbGOuZr1D6Sr7uuDYn3V7o+lZQUqpLpmIUzLIksSPrFCt+JRjXQ GVIdsCTAzN/0wafzhuBJHJq89+ja5G+wVFedITcyIvEtIHv1djDhJf6Xcyh5YHm+UOZ6 nloNm9e7MWJ2vMJqz2bVEnfWkkGgcdKzlo4hhqA/RlwVYAHx3Co1hp8NLptjya6r3Hl5 Y+Pw== X-Gm-Message-State: ALoCoQlPjO7fg6a4qIUXpJOTK5urx9jKIIbetVL8h56Vr6kU5Nt9ovvNpOlj+/PvD4TUtTpHv0vZ X-Received: by 10.107.134.9 with SMTP id i9mr29911903iod.90.1427475159461; Fri, 27 Mar 2015 09:52:39 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-98-250-104-235.hsd1.mi.comcast.net. [98.250.104.235]) by mx.google.com with ESMTPSA id f1sm1686752igt.14.2015.03.27.09.52.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Mar 2015 09:52:38 -0700 (PDT) From: Trond Myklebust To: Kinglong Mee Cc: linux-nfs@vger.kernel.org Subject: [PATCH] NFSv4: Return delegations synchronously in evict_inode Date: Fri, 27 Mar 2015 12:52:37 -0400 Message-Id: <1427475157-13904-1-git-send-email-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Kinglong Mee reports that asynchronous delegations are being killed by the call to rpc_shutdown_client() when unmounting. This can lead to state leakage on the server until the client lease expires. Reported-by: Kinglong Mee Signed-off-by: Trond Myklebust Tested-by: Kinglong Mee --- fs/nfs/delegation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c index a6ad68865880..08c624448750 100644 --- a/fs/nfs/delegation.c +++ b/fs/nfs/delegation.c @@ -514,7 +514,7 @@ void nfs_inode_return_delegation_noreclaim(struct inode *inode) delegation = nfs_inode_detach_delegation(inode); if (delegation != NULL) - nfs_do_return_delegation(inode, delegation, 0); + nfs_do_return_delegation(inode, delegation, 1); } /**