diff mbox

[1/2] mountstats: Resync NFSv4 Operations List

Message ID 1428511647-14920-2-git-send-email-Anna.Schumaker@Netapp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Schumaker, Anna April 8, 2015, 4:47 p.m. UTC 
We've added several operations and removed GETDEVICELIST,  Let's keep
the Nfsv4ops list up to date with the kernel.

Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
 tools/mountstats/mountstats.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Christoph Hellwig April 8, 2015, 5:57 p.m. UTC | #1 
On Wed, Apr 08, 2015 at 12:47:26PM -0400, Anna Schumaker wrote:
> We've added several operations and removed GETDEVICELIST,  Let's keep
> the Nfsv4ops list up to date with the kernel.

Please keep GETDEVICELIST, as newer mountstats should handle older
kernels as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Schumaker, Anna April 8, 2015, 6:13 p.m. UTC | #2 
On 04/08/2015 01:57 PM, Christoph Hellwig wrote:
> On Wed, Apr 08, 2015 at 12:47:26PM -0400, Anna Schumaker wrote:
>> We've added several operations and removed GETDEVICELIST,  Let's keep
>> the Nfsv4ops list up to date with the kernel.
> 
> Please keep GETDEVICELIST, as newer mountstats should handle older
> kernels as well.
> 
Fair enough.  I'm also working on a patch to add GETDEVICELIST back into the client.

Anna
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 38943eb..8f2e26e 100644
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -195,16 +195,18 @@  Nfsv4ops = [
     'SEQUENCE',
     'GET_LEASE_TIME',
     'RECLAIM_COMPLETE',
-    'LAYOUTGET',
     'GETDEVICEINFO',
+    'LAYOUTGET',
     'LAYOUTCOMMIT',
     'LAYOUTRETURN',
     'SECINFO_NO_NAME',
     'TEST_STATEID',
     'FREE_STATEID',
-    'GETDEVICELIST',
     'BIND_CONN_TO_SESSION',
-    'DESTROY_CLIENTID'
+    'DESTROY_CLIENTID',
+    'SEEK',
+    'ALLOCATE',
+    'DEALLOCATE',
 ]
 
 class DeviceData: