diff mbox

[RFC,03/11] nfs42: decode_layoutstats does not need res parameter

Message ID 1440516829-116041-4-git-send-email-tao.peng@primarydata.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peng Tao Aug. 25, 2015, 3:33 p.m. UTC 
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Peng Tao <tao.peng@primarydata.com>
---
 fs/nfs/nfs42xdr.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Schumaker, Anna Aug. 25, 2015, 4:04 p.m. UTC | #1 
Hey Tao,

Should this be sent as a separate patch?  It could probably be included now, rather than waiting on the rest of the CLONE patches to filter through.

Thanks,
Anna

On 08/25/2015 11:33 AM, Peng Tao wrote:
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Peng Tao <tao.peng@primarydata.com>
> ---
>  fs/nfs/nfs42xdr.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfs/nfs42xdr.c b/fs/nfs/nfs42xdr.c
> index a6bd27d..0eb29e1 100644
> --- a/fs/nfs/nfs42xdr.c
> +++ b/fs/nfs/nfs42xdr.c
> @@ -238,8 +238,7 @@ out_overflow:
>  	return -EIO;
>  }
>  
> -static int decode_layoutstats(struct xdr_stream *xdr,
> -			      struct nfs42_layoutstat_res *res)
> +static int decode_layoutstats(struct xdr_stream *xdr)
>  {
>  	return decode_op_hdr(xdr, OP_LAYOUTSTATS);
>  }
> @@ -343,7 +342,7 @@ static int nfs4_xdr_dec_layoutstats(struct rpc_rqst *rqstp,
>  		goto out;
>  	WARN_ON(res->num_dev > PNFS_LAYOUTSTATS_MAXDEV);
>  	for (i = 0; i < res->num_dev; i++) {
> -		status = decode_layoutstats(xdr, res);
> +		status = decode_layoutstats(xdr);
>  		if (status)
>  			goto out;
>  	}
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfs/nfs42xdr.c b/fs/nfs/nfs42xdr.c
index a6bd27d..0eb29e1 100644
--- a/fs/nfs/nfs42xdr.c
+++ b/fs/nfs/nfs42xdr.c
@@ -238,8 +238,7 @@  out_overflow:
 	return -EIO;
 }
 
-static int decode_layoutstats(struct xdr_stream *xdr,
-			      struct nfs42_layoutstat_res *res)
+static int decode_layoutstats(struct xdr_stream *xdr)
 {
 	return decode_op_hdr(xdr, OP_LAYOUTSTATS);
 }
@@ -343,7 +342,7 @@  static int nfs4_xdr_dec_layoutstats(struct rpc_rqst *rqstp,
 		goto out;
 	WARN_ON(res->num_dev > PNFS_LAYOUTSTATS_MAXDEV);
 	for (i = 0; i < res->num_dev; i++) {
-		status = decode_layoutstats(xdr, res);
+		status = decode_layoutstats(xdr);
 		if (status)
 			goto out;
 	}