diff mbox

[RFC,04/11] nfs42: remove unused declaration

Message ID 1440516829-116041-5-git-send-email-tao.peng@primarydata.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peng Tao Aug. 25, 2015, 3:33 p.m. UTC 
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Peng Tao <tao.peng@primarydata.com>
---
 fs/nfs/nfs42.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Schumaker, Anna Aug. 25, 2015, 4:05 p.m. UTC | #1 
Hi Tao,

On 08/25/2015 11:33 AM, Peng Tao wrote:
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Peng Tao <tao.peng@primarydata.com>
> ---
>  fs/nfs/nfs42.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/nfs/nfs42.h b/fs/nfs/nfs42.h
> index ff66ae7..814c125 100644
> --- a/fs/nfs/nfs42.h
> +++ b/fs/nfs/nfs42.h
> @@ -17,7 +17,5 @@ int nfs42_proc_deallocate(struct file *, loff_t, loff_t);
>  loff_t nfs42_proc_llseek(struct file *, loff_t, int);
>  int nfs42_proc_layoutstats_generic(struct nfs_server *,
>  				   struct nfs42_layoutstat_data *);
> -/* nfs4.2xdr.h */
> -extern struct rpc_procinfo nfs4_2_procedures[];

Same thing here.  Maybe submit both patches together as a cleanup patch series?

Thanks,
Anna

>  
>  #endif /* __LINUX_FS_NFS_NFS4_2_H */
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Peng Tao Aug. 25, 2015, 4:08 p.m. UTC | #2 
On Wed, Aug 26, 2015 at 12:05 AM, Anna Schumaker
<Anna.Schumaker@netapp.com> wrote:
> Hi Tao,
>
> On 08/25/2015 11:33 AM, Peng Tao wrote:
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Peng Tao <tao.peng@primarydata.com>
>> ---
>>  fs/nfs/nfs42.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/nfs/nfs42.h b/fs/nfs/nfs42.h
>> index ff66ae7..814c125 100644
>> --- a/fs/nfs/nfs42.h
>> +++ b/fs/nfs/nfs42.h
>> @@ -17,7 +17,5 @@ int nfs42_proc_deallocate(struct file *, loff_t, loff_t);
>>  loff_t nfs42_proc_llseek(struct file *, loff_t, int);
>>  int nfs42_proc_layoutstats_generic(struct nfs_server *,
>>                                  struct nfs42_layoutstat_data *);
>> -/* nfs4.2xdr.h */
>> -extern struct rpc_procinfo nfs4_2_procedures[];
>
> Same thing here.  Maybe submit both patches together as a cleanup patch series?
>
Will do. Thanks!

Cheers,
Tao
> Thanks,
> Anna
>
>>
>>  #endif /* __LINUX_FS_NFS_NFS4_2_H */
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfs/nfs42.h b/fs/nfs/nfs42.h
index ff66ae7..814c125 100644
--- a/fs/nfs/nfs42.h
+++ b/fs/nfs/nfs42.h
@@ -17,7 +17,5 @@  int nfs42_proc_deallocate(struct file *, loff_t, loff_t);
 loff_t nfs42_proc_llseek(struct file *, loff_t, int);
 int nfs42_proc_layoutstats_generic(struct nfs_server *,
 				   struct nfs42_layoutstat_data *);
-/* nfs4.2xdr.h */
-extern struct rpc_procinfo nfs4_2_procedures[];
 
 #endif /* __LINUX_FS_NFS_NFS4_2_H */