| Message ID | 1441394647-16412-1-git-send-email-trond.myklebust@primarydata.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sep 4, 2015, at 3:24 PM, Trond Myklebust <trond.myklebust@primarydata.com> wrote: > If there is no cached data, then there is no need to track the file > change attribute on close. This makes sense. nfs_close_context() is only used by NFSv2 and NFSv3. Should you update the documenting comment? > Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> > --- > fs/nfs/inode.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c > index 99a68bd9c178..ebaf991e4b02 100644 > --- a/fs/nfs/inode.c > +++ b/fs/nfs/inode.c > @@ -766,6 +766,7 @@ EXPORT_SYMBOL_GPL(nfs_put_lock_context); > */ > void nfs_close_context(struct nfs_open_context *ctx, int is_sync) > { > + struct nfs_inode *nfsi; > struct inode *inode; > struct nfs_server *server; > > @@ -774,7 +775,12 @@ void nfs_close_context(struct nfs_open_context *ctx, int is_sync) > if (!is_sync) > return; > inode = d_inode(ctx->dentry); > - if (!list_empty(&NFS_I(inode)->open_files)) > + nfsi = NFS_I(inode); > + if (inode->i_mapping->nrpages == 0) > + return; > + if (nfsi->cache_validity & NFS_INO_INVALID_DATA) > + return; > + if (!list_empty(&nfsi->open_files)) > return; > server = NFS_SERVER(inode); > if (server->flags & NFS_MOUNT_NOCTO) > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Sep 4, 2015 at 3:38 PM, Chuck Lever <chuck.lever@oracle.com> wrote: > > On Sep 4, 2015, at 3:24 PM, Trond Myklebust <trond.myklebust@primarydata.com> wrote: > >> If there is no cached data, then there is no need to track the file >> change attribute on close. > > This makes sense. nfs_close_context() is only used by NFSv2 > and NFSv3. > > Should you update the documenting comment? Good point. I'll do that... -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 99a68bd9c178..ebaf991e4b02 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -766,6 +766,7 @@ EXPORT_SYMBOL_GPL(nfs_put_lock_context); */ void nfs_close_context(struct nfs_open_context *ctx, int is_sync) { + struct nfs_inode *nfsi; struct inode *inode; struct nfs_server *server; @@ -774,7 +775,12 @@ void nfs_close_context(struct nfs_open_context *ctx, int is_sync) if (!is_sync) return; inode = d_inode(ctx->dentry); - if (!list_empty(&NFS_I(inode)->open_files)) + nfsi = NFS_I(inode); + if (inode->i_mapping->nrpages == 0) + return; + if (nfsi->cache_validity & NFS_INO_INVALID_DATA) + return; + if (!list_empty(&nfsi->open_files)) return; server = NFS_SERVER(inode); if (server->flags & NFS_MOUNT_NOCTO)
If there is no cached data, then there is no need to track the file change attribute on close. Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> --- fs/nfs/inode.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)