From patchwork Thu Oct 15 16:09:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew W Elble X-Patchwork-Id: 7407601 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F2DBCBEEA4 for ; Thu, 15 Oct 2015 16:09:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 189A92061D for ; Thu, 15 Oct 2015 16:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3852F2061B for ; Thu, 15 Oct 2015 16:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752332AbbJOQJ1 (ORCPT ); Thu, 15 Oct 2015 12:09:27 -0400 Received: from discipline.rit.edu ([129.21.6.207]:33654 "HELO discipline.rit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751374AbbJOQJ1 (ORCPT ); Thu, 15 Oct 2015 12:09:27 -0400 Received: (qmail 20817 invoked by uid 501); 15 Oct 2015 16:09:26 -0000 From: Andrew Elble To: linux-nfs@vger.kernel.org Cc: Andrew Elble Subject: [PATCH RFC] nfsd: don't revoke delegations that a client has stated it doesn't have Date: Thu, 15 Oct 2015 12:09:19 -0400 Message-Id: <1444925359-18251-1-git-send-email-aweits@rit.edu> X-Mailer: git-send-email 2.4.6 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Assuming a client has lost a delegation: If the server goes to recall the delegation, an attempt is made to recall it twice separated by a delay of 2 seconds. Both times, the client will state that it doesn't have the delegation via -EBADHANDLE or -NFS4ERR_BAD_STATEID. 1.) Any race between a delegation grant and a recall has been presumably avoided by the delay and second attempt. 2.) The client doesn't have the delegation. 3.) The backchannel is responsive. After these two attempts fail, the laundromat will eventually revoke them and add these delegations to cl_revoked. This results in another attempt to get the client to return the delegation via TEST/FREE STATEID. This will also fail with no means of resolution, and will cause the server and client to loop indefinitely, as the client has nothing to give the server to satisfy it. The changes here are to establish a safe way to recover by: If the client has responded with -EBADHANDLE or -NFS4ERR_BAD_STATEID: 1.) Not failing the backchannel after two attempts at a recall. 2.) At the time revocation would normally occur: destroying the delegation on the server side. Signed-off-by: Andrew Elble --- fs/nfsd/nfs4state.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index da21df673ed9..34d928bd847d 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -3578,7 +3578,7 @@ static int nfsd4_cb_recall_done(struct nfsd4_callback *cb, rpc_delay(task, 2 * HZ); return 0; } - /*FALLTHRU*/ + return 1; default: return -1; } @@ -4450,8 +4450,16 @@ nfs4_laundromat(struct nfsd_net *nn) while (!list_empty(&reaplist)) { dp = list_first_entry(&reaplist, struct nfs4_delegation, dl_recall_lru); - list_del_init(&dp->dl_recall_lru); - revoke_delegation(dp); + if ((dp->dl_recall.cb_status == -EBADHANDLE) || + (dp->dl_recall.cb_status == -NFS4ERR_BAD_STATEID)) { + dprintk("nfsd: client: %.*s is losing delegations", + (int)dp->dl_recall.cb_clp->cl_name.len, + dp->dl_recall.cb_clp->cl_name.data); + destroy_delegation(dp); + } else { + list_del_init(&dp->dl_recall_lru); + revoke_delegation(dp); + } } spin_lock(&nn->client_lock);