diff mbox

[4/4] nfsd: Provide a config option for flex file layouts

Message ID 1464152979-103988-5-git-send-email-loghyr@primarydata.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thomas Haynes May 25, 2016, 5:09 a.m. UTC
Signed-off-by: Tom Haynes <loghyr@primarydata.com>
---
 fs/nfsd/Kconfig | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Christoph Hellwig May 25, 2016, 3:09 p.m. UTC | #1
> +config NFSD_FLEXFILELAYOUT
> +	bool "NFSv4.1 server support for pNFS Flex File layouts"
> +	depends on NFSD_V4
> +	select NFSD_PNFS
> +	help
> +	  This option enables support for the exporting pNFS Flex File
> +	  layouts in the kernel's NFS server. The pNFS Flex File  layout
> +	  enables NFS clients to directly perform I/O to NFSv3 devices
> +	  accesible to both the server and the clients.  See
> +	  draft-ietf-nfsv4-flex-files for more details.

How about a bit more of a warning that this is just a toy demo server?

Also I'd say merge this into the previous patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thomas Haynes May 25, 2016, 6:19 p.m. UTC | #2
> On May 25, 2016, at 8:09 AM, Christoph Hellwig <hch@lst.de> wrote:
> 
>> +config NFSD_FLEXFILELAYOUT
>> +	bool "NFSv4.1 server support for pNFS Flex File layouts"
>> +	depends on NFSD_V4
>> +	select NFSD_PNFS
>> +	help
>> +	  This option enables support for the exporting pNFS Flex File
>> +	  layouts in the kernel's NFS server. The pNFS Flex File  layout
>> +	  enables NFS clients to directly perform I/O to NFSv3 devices
>> +	  accesible to both the server and the clients.  See
>> +	  draft-ietf-nfsv4-flex-files for more details.
> 
> How about a bit more of a warning that this is just a toy demo server?
> 

Add:

          Warning, this server implements the bare minimum functionality for
          to be a flex file server - it is more for testing the client
          than for a production server.




> Also I'd say merge this into the previous patch.
> 

Agreed

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
J. Bruce Fields May 25, 2016, 6:21 p.m. UTC | #3
On Wed, May 25, 2016 at 06:19:20PM +0000, Thomas Haynes wrote:
> 
> > On May 25, 2016, at 8:09 AM, Christoph Hellwig <hch@lst.de> wrote:
> > 
> >> +config NFSD_FLEXFILELAYOUT
> >> +	bool "NFSv4.1 server support for pNFS Flex File layouts"
> >> +	depends on NFSD_V4
> >> +	select NFSD_PNFS
> >> +	help
> >> +	  This option enables support for the exporting pNFS Flex File
> >> +	  layouts in the kernel's NFS server. The pNFS Flex File  layout
> >> +	  enables NFS clients to directly perform I/O to NFSv3 devices
> >> +	  accesible to both the server and the clients.  See
> >> +	  draft-ietf-nfsv4-flex-files for more details.
> > 
> > How about a bit more of a warning that this is just a toy demo server?
> > 
> 
> Add:
> 
>           Warning, this server implements the bare minimum functionality for
>           to be a flex file server - it is more for testing the client
>           than for a production server.

I'd leave out the "more", and just say "it is for testing the client,
not for use in production".

Which makes me wonder whether it's even worth merging.

But it's very small and self-contained, so I'm inclined to go ahead,
pending other review.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
index c9f583d..76edffb 100644
--- a/fs/nfsd/Kconfig
+++ b/fs/nfsd/Kconfig
@@ -111,6 +111,19 @@  config NFSD_SCSILAYOUT
 
 	  If unsure, say N.
 
+config NFSD_FLEXFILELAYOUT
+	bool "NFSv4.1 server support for pNFS Flex File layouts"
+	depends on NFSD_V4
+	select NFSD_PNFS
+	help
+	  This option enables support for the exporting pNFS Flex File
+	  layouts in the kernel's NFS server. The pNFS Flex File  layout
+	  enables NFS clients to directly perform I/O to NFSv3 devices
+	  accesible to both the server and the clients.  See
+	  draft-ietf-nfsv4-flex-files for more details.
+
+	  If unsure, say N.
+
 config NFSD_V4_SECURITY_LABEL
 	bool "Provide Security Label support for NFSv4 server"
 	depends on NFSD_V4 && SECURITY