From patchwork Wed Jun 22 20:47:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 9193749 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4A04F6075C for ; Wed, 22 Jun 2016 20:48:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AFBF2840B for ; Wed, 22 Jun 2016 20:48:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2FF7628416; Wed, 22 Jun 2016 20:48:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2E522840B for ; Wed, 22 Jun 2016 20:48:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751630AbcFVUsZ (ORCPT ); Wed, 22 Jun 2016 16:48:25 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:35071 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbcFVUsY (ORCPT ); Wed, 22 Jun 2016 16:48:24 -0400 Received: by mail-io0-f195.google.com with SMTP id u25so8584986iou.2 for ; Wed, 22 Jun 2016 13:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=qbktNfLrEOOhI3MecfwOrw15tf2UOhIBGkSeYqjPiy4=; b=0rPJvvF17Vc499q1bcGZfK6QhUef1UgEsm10p4alCkp4bpRCfUFM9yS+e5Yr8vxnEi Vp3CaeadVPLPtheL0L7PYZ1OyTmWX77gfSBdkK+j0iTqMbsTiagqYwFnPh7SsyEx1exd 0yPFOKWwaejK5/T6Lg3oyDy1raT/ZMVllzuWJHrP35aPU2P7cmYBREqzf0p0SiFaS+G6 hccDpynyJ4ZnSAc81KPwH9CRCyFIFElJLG7LNto2f0GIQdw5ouVWDqXj+aGAit3YLZCL Hx5qbbVa8uedBC92NXDszXhuLXbkENqiXoc8L+RklQcznfl/LT4GdknBxCfVJasQ7W4U sXmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=qbktNfLrEOOhI3MecfwOrw15tf2UOhIBGkSeYqjPiy4=; b=K6WHmiHIcTUkibjAizc2UjJMvde3Lj1XxZ+InaI//PeCk4DRDd7EwDrPqJL9YoQiSA PZ/LLGCI76Su60vQzSB04tIERkiTrQetmlU/IrknbllPKEtlce8Ztyd5ZSyz335MD6RO yN/FAcPNycPHpj/JGz8528pbPMt9CGZ4i5fHkkkdFNhwE8h6+EnqLUNsTjZUAnlHonRO ysfRmQn4fZr7f6f2r01aZQzxVzBKnLP03MdsRmu4KLfB2/puoiBj2gBbzO7PmbD0RTDO JRnrt3+TGwa9PXZis4tj6E3RTi/bakXgDzgo/EXrZp6Q6fcaYyT2kz+rnGTBFyLGH20O bKew== X-Gm-Message-State: ALyK8tLQuJ3YnFsdKrwbrTjvzbRxD2OSTvU49bO+suX+FRgAInf9y4rxSONDgTuGMQwntg== X-Received: by 10.107.198.194 with SMTP id w185mr42415807iof.146.1466628503880; Wed, 22 Jun 2016 13:48:23 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-49-162-121.hsd1.mi.comcast.net. [68.49.162.121]) by smtp.gmail.com with ESMTPSA id m133sm1061586ioa.23.2016.06.22.13.48.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jun 2016 13:48:23 -0700 (PDT) From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH v3 06/13] NFS: Don't hold the inode lock across fsync() Date: Wed, 22 Jun 2016 16:47:41 -0400 Message-Id: <1466628468-3958-6-git-send-email-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1466628468-3958-5-git-send-email-trond.myklebust@primarydata.com> References: <1466628468-3958-1-git-send-email-trond.myklebust@primarydata.com> <1466628468-3958-2-git-send-email-trond.myklebust@primarydata.com> <1466628468-3958-3-git-send-email-trond.myklebust@primarydata.com> <1466628468-3958-4-git-send-email-trond.myklebust@primarydata.com> <1466628468-3958-5-git-send-email-trond.myklebust@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commits are no longer required to be serialised. Signed-off-by: Trond Myklebust --- fs/nfs/file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/file.c b/fs/nfs/file.c index 29d7477a62e8..249262b6bcbe 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c @@ -277,11 +277,9 @@ nfs_file_fsync(struct file *file, loff_t start, loff_t end, int datasync) ret = filemap_write_and_wait_range(inode->i_mapping, start, end); if (ret != 0) break; - inode_lock(inode); ret = nfs_file_fsync_commit(file, start, end, datasync); if (!ret) ret = pnfs_sync_inode(inode, !!datasync); - inode_unlock(inode); /* * If nfs_file_fsync_commit detected a server reboot, then * resend all dirty pages that might have been covered by