diff mbox

[v25,04/22] vfs: Make the inode passed to inode_change_ok non-const

Message ID 1471345383-15334-5-git-send-email-agruenba@redhat.com (mailing list archive)
State Under Review
Headers show

Commit Message

Andreas Gruenbacher Aug. 16, 2016, 11:02 a.m. UTC
We will need to call iop->permission and iop->get_acl from
inode_change_ok() for additional permission checks, and both take a
non-const inode.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: J. Bruce Fields <bfields@redhat.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Reviewed-by: Steve French <steve.french@primarydata.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
 fs/attr.c          | 2 +-
 include/linux/fs.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff mbox


diff --git a/fs/attr.c b/fs/attr.c
index 42bb42b..a4b7d2f 100644
--- a/fs/attr.c
+++ b/fs/attr.c
@@ -28,7 +28,7 @@ 
  * Should be called as the first thing in ->setattr implementations,
  * possibly after taking additional locks.
-int inode_change_ok(const struct inode *inode, struct iattr *attr)
+int inode_change_ok(struct inode *inode, struct iattr *attr)
 	unsigned int ia_valid = attr->ia_valid;
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 907869d..0d6ac2c 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3010,7 +3010,7 @@  extern int buffer_migrate_page(struct address_space *,
 #define buffer_migrate_page NULL
-extern int inode_change_ok(const struct inode *, struct iattr *);
+extern int inode_change_ok(struct inode *, struct iattr *);
 extern int inode_newsize_ok(const struct inode *, loff_t offset);
 extern void setattr_copy(struct inode *inode, const struct iattr *attr);