| Message ID | 1472416615-24079-1-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
On Sun, 2016-08-28 at 22:36 +0200, Julia Lawall wrote: > reply_cache_stats_operations, of type struct file_operations, is > never > modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > fs/nfsd/nfsctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > index 65ad016..3bc9693 100644 > --- a/fs/nfsd/nfsctl.c > +++ b/fs/nfsd/nfsctl.c > @@ -217,7 +217,7 @@ static const struct file_operations > pool_stats_operations = { > .release = nfsd_pool_stats_release, > }; > > -static struct file_operations reply_cache_stats_operations = { > +static const struct file_operations reply_cache_stats_operations = { > .open = nfsd_reply_cache_stats_open, > .read = seq_read, > .llseek = seq_lseek, > I'm pretty sure Bruce will pick this up for v4.9: Reviewed-by: Jeff Layton <jlayton@poochiereds.net> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 29, 2016 at 06:57:47AM -0400, Jeff Layton wrote: > On Sun, 2016-08-28 at 22:36 +0200, Julia Lawall wrote: > > reply_cache_stats_operations, of type struct file_operations, is > > never > > modified, so declare it as const. > > > > Done with the help of Coccinelle. > > > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > > > --- > > fs/nfsd/nfsctl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c > > index 65ad016..3bc9693 100644 > > --- a/fs/nfsd/nfsctl.c > > +++ b/fs/nfsd/nfsctl.c > > @@ -217,7 +217,7 @@ static const struct file_operations > > pool_stats_operations = { > > .release = nfsd_pool_stats_release, > > }; > > > > -static struct file_operations reply_cache_stats_operations = { > > +static const struct file_operations reply_cache_stats_operations = { > > .open = nfsd_reply_cache_stats_open, > > .read = seq_read, > > .llseek = seq_lseek, > > > > I'm pretty sure Bruce will pick this up for v4.9: Except, for some reason it's been languishing in my inbox. Apologies, applying.... --b. > > Reviewed-by: Jeff Layton <jlayton@poochiereds.net> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 65ad016..3bc9693 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -217,7 +217,7 @@ static const struct file_operations pool_stats_operations = { .release = nfsd_pool_stats_release, }; -static struct file_operations reply_cache_stats_operations = { +static const struct file_operations reply_cache_stats_operations = { .open = nfsd_reply_cache_stats_open, .read = seq_read, .llseek = seq_lseek,
reply_cache_stats_operations, of type struct file_operations, is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- fs/nfsd/nfsctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html