diff mbox

[Version,9,RESEND,05/12] SUNRPC remove rpc_task_release_client from rpc_task_set_client

Message ID 1472744693-124241-6-git-send-email-andros@netapp.com (mailing list archive)
State Under Review
Delegated to: Trond Myklebust
Headers show

Commit Message

Andy Adamson Sept. 1, 2016, 3:44 p.m. UTC
From: Andy Adamson <andros@netapp.com>

rpc_task_set_client is only called from rpc_run_task after
rpc_new_task and rpc_task_release_client is not needed as the
task is new.

When called from rpc_new_task, rpc_task_set_client also removed the
assigned rpc_xprt which is not desired.

Signed-off-by: Andy Adamson <andros@netapp.com>
 net/sunrpc/clnt.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox


diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index cb49898..163b8f4 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -988,7 +988,6 @@  void rpc_task_set_client(struct rpc_task *task, struct rpc_clnt *clnt)
 	if (clnt != NULL) {
-		rpc_task_release_client(task);
 		if (task->tk_xprt == NULL)
 			task->tk_xprt = xprt_iter_get_next(&clnt->cl_xpi);
 		task->tk_client = clnt;