From patchwork Sat Sep 17 05:13:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 9336971 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 515F16089F for ; Sat, 17 Sep 2016 05:13:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4256D29FBE for ; Sat, 17 Sep 2016 05:13:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 372C229FCF; Sat, 17 Sep 2016 05:13:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2AE129FCB for ; Sat, 17 Sep 2016 05:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755291AbcIQFNq (ORCPT ); Sat, 17 Sep 2016 01:13:46 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:33392 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753826AbcIQFNo (ORCPT ); Sat, 17 Sep 2016 01:13:44 -0400 Received: by mail-io0-f196.google.com with SMTP id r145so2386723ior.0 for ; Fri, 16 Sep 2016 22:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=JwEDNKtDqZizsD1AGaiOeptcRk2oFRyEkjfH5fNoqcA=; b=jQFTjxeCUPFC1JljkIiR9Ao2x6FleCdfztc79sxRN6RpH84R2G8cgiv23go/101sLy KHOORexJMRe6rmnsilqHkEfaw/7adhDYsyJAGeFL4PcZ2rICxnVkkL55vfEgIU8VFxRf xhs6VlsNCouQrUpEOnhX9rB8JDeDO7jfz7WymqLbUW2PGrXToauV/HIDfwKmqMNOI7et coFwfk26u8dwoagopnbQz5stVVYfBk3jvDRVp9LBBfZsRLpCkepNwssXeEvbqlqHzccK FLFJaht3a3vIL9ldzpvcaPptuy56MtHklU+nidLu5VNO4dLaVgdlL6mIRTeRheiy1pHX fWGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=JwEDNKtDqZizsD1AGaiOeptcRk2oFRyEkjfH5fNoqcA=; b=Ty/XelBzpXj+7726I1NO5nikQaTSoIHgQEea/DJ+HeowkcVbfo9AsOxlm+hGAcKbfu QpTg4DtAaqVIxwCpVZtSexbjlKc0cC7XAY4DSVcRGcgdxS4mArFrtkldaJNpYfi6y0Lw 4+VftjWAvviIxgOONuBdkEnEF5I2UCMSIYRUmzv//p5UwH7Ek78PChUy6eDAds7EZ82I 8/IhZlyJxncGFb9tRoMMCBBPx0LtQu2KfjGsLMwXPX2PqEmPrZ2YfR62HcsJLqvYMEDU Wg5ArlRrZ9nmcfcPJ9SkDCzbyjecOFmZqqFE2V6V72W5Ej1W3MLshOkTzZVaanEJKllE 9d9Q== X-Gm-Message-State: AE9vXwMlwThVZW4S6/1beX2IUVj0kOWyjaIR5r89tJHW7tThBvBW2lNRa0pa65O8zA8JKA== X-Received: by 10.107.19.37 with SMTP id b37mr28353921ioj.162.1474089224117; Fri, 16 Sep 2016 22:13:44 -0700 (PDT) Received: from leira.trondhjem.org.localdomain (c-68-49-162-121.hsd1.mi.comcast.net. [68.49.162.121]) by smtp.gmail.com with ESMTPSA id d15sm4993916ioj.19.2016.09.16.22.13.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Sep 2016 22:13:43 -0700 (PDT) From: Trond Myklebust To: anna.schumaker@netapp.com Cc: linux-nfs@vger.kernel.org, Oleg Drokin Subject: [PATCH v5 09/25] NFSv4.1: Don't recheck delegations that have already been checked Date: Sat, 17 Sep 2016 01:13:17 -0400 Message-Id: <1474089213-104014-10-git-send-email-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1474089213-104014-9-git-send-email-trond.myklebust@primarydata.com> References: <1474089213-104014-1-git-send-email-trond.myklebust@primarydata.com> <1474089213-104014-2-git-send-email-trond.myklebust@primarydata.com> <1474089213-104014-3-git-send-email-trond.myklebust@primarydata.com> <1474089213-104014-4-git-send-email-trond.myklebust@primarydata.com> <1474089213-104014-5-git-send-email-trond.myklebust@primarydata.com> <1474089213-104014-6-git-send-email-trond.myklebust@primarydata.com> <1474089213-104014-7-git-send-email-trond.myklebust@primarydata.com> <1474089213-104014-8-git-send-email-trond.myklebust@primarydata.com> <1474089213-104014-9-git-send-email-trond.myklebust@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Ensure we don't spam the server with test_stateid() calls for delegations that have already been checked. Signed-off-by: Trond Myklebust --- fs/nfs/nfs4proc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 3552f3a4ceb0..97a614370604 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2459,6 +2459,11 @@ static void nfs41_check_delegation_stateid(struct nfs4_state *state) return; } + if (!test_and_clear_bit(NFS_DELEGATION_TEST_EXPIRED, &delegation->flags)) { + rcu_read_unlock(); + return; + } + cred = get_rpccred(delegation->cred); rcu_read_unlock(); status = nfs41_test_and_free_expired_stateid(server, &stateid, cred);