From patchwork Thu Nov 10 21:41:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 9422099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D01DA60512 for ; Thu, 10 Nov 2016 21:41:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B186428CA3 for ; Thu, 10 Nov 2016 21:41:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4ADB297A4; Thu, 10 Nov 2016 21:41:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4EC5228CA3 for ; Thu, 10 Nov 2016 21:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936286AbcKJVlT (ORCPT ); Thu, 10 Nov 2016 16:41:19 -0500 Received: from mail-it0-f68.google.com ([209.85.214.68]:33829 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934551AbcKJVlS (ORCPT ); Thu, 10 Nov 2016 16:41:18 -0500 Received: by mail-it0-f68.google.com with SMTP id q124so6238199itd.1 for ; Thu, 10 Nov 2016 13:41:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=NYe282W8gRjzkr/Y/CSUKqKnkx16jL10TEBIRXxLAwk=; b=OnG2qLeodfL4MQ1fTGJlqUUsBWYPkZcHN/Z+f3NyQeF4jUhAYOSdiofv2rPpR+yAgL YOaTNFnlG8Xwx+YfudoanWqhse8OpageHXpbgEEyLzwdelPg1L0/5zaNr1lhmP5uONBN +xfdGoiYdtTP7R6W+XekpRJLATpFYfzPI0R7bcfFdF1GwtZR0liLZUTT/TQT5+2SPJ+C 1JXYQag3wufSv7/MnYy/MEQzjmTJRvomEEm1bKTxsH1NLrnxFjQWGqbMT9Uzk5JxPtS3 hIJ86R2UJ9mvOMMRrlVJqhJurMrwJZAwz0yrHu1snF9P8c6/S6N2mC9d0UmX4px89Np3 JrcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=NYe282W8gRjzkr/Y/CSUKqKnkx16jL10TEBIRXxLAwk=; b=L2yuHYa9rGiglW/miVvrn4nKNpxr5IWyNAkyty0DVTbn9uZVPbYAsSCwipiJTlsUEG VZOpA7rQ6tZNhXMlbplY+otywb61e93Vacj72JI5a9gGIHfHjCG+SDbV8BBx49SJ0H37 s2p+WeYRovVhAee3In0u1XUpzKjyYJo8WWdXekALNx8egvpRKDpr72SQNCbzO97xS35F mPrqHVa4JVoq/HqLIWg65OOhR1vsgrxTdoom5wUtgnK3J1Nx5dFoyd8gZJgjisOh5+RJ M4OsLUBwetwTjCRxjHN3hxn43scV77Fk4Ao5zIBBusTxA6CzFnkf+p2zlkEHxHWDyKGC JLpQ== X-Gm-Message-State: ABUngvc4Wpgz1Mm8bJl4IxZkVF0Jp+bFXcW/RBrYyuoCSl23jINIctfj592IjPbc7/q3hA== X-Received: by 10.107.197.66 with SMTP id v63mr8364358iof.119.1478814077659; Thu, 10 Nov 2016 13:41:17 -0800 (PST) Received: from leira.trondhjem.org.localdomain (c-68-49-162-121.hsd1.mi.comcast.net. [68.49.162.121]) by smtp.gmail.com with ESMTPSA id g185sm2714645ith.14.2016.11.10.13.41.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2016 13:41:17 -0800 (PST) From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH 4/5] NFSv4: Don't request close-to-open attribute when holding a delegation Date: Thu, 10 Nov 2016 16:41:09 -0500 Message-Id: <1478814070-17140-5-git-send-email-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1478814070-17140-4-git-send-email-trond.myklebust@primarydata.com> References: <1478814070-17140-1-git-send-email-trond.myklebust@primarydata.com> <1478814070-17140-2-git-send-email-trond.myklebust@primarydata.com> <1478814070-17140-3-git-send-email-trond.myklebust@primarydata.com> <1478814070-17140-4-git-send-email-trond.myklebust@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If holding a delegation, we do not need to ask the server to return close-to-open cache consistency attributes as part of the CLOSE compound. Signed-off-by: Trond Myklebust --- fs/nfs/nfs4proc.c | 10 ++++++++-- fs/nfs/nfs4xdr.c | 3 ++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 1e7e0754a96d..ded8854bc32f 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3141,8 +3141,15 @@ static void nfs4_close_prepare(struct rpc_task *task, void *data) goto out_wait; } - if (calldata->arg.fmode == 0) + if (calldata->arg.fmode == 0) { task->tk_msg.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_CLOSE]; + + /* Close-to-open cache consistency revalidation */ + if (!nfs4_have_delegation(inode, FMODE_READ)) + calldata->arg.bitmask = NFS_SERVER(inode)->cache_consistency_bitmask; + else + calldata->arg.bitmask = NULL; + } if (calldata->roc) pnfs_roc_get_barrier(inode, &calldata->roc_barrier); @@ -3225,7 +3232,6 @@ int nfs4_do_close(struct nfs4_state *state, gfp_t gfp_mask, int wait) if (IS_ERR(calldata->arg.seqid)) goto out_free_calldata; calldata->arg.fmode = 0; - calldata->arg.bitmask = server->cache_consistency_bitmask; calldata->res.fattr = &calldata->fattr; calldata->res.seqid = calldata->arg.seqid; calldata->res.server = server; diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index 43cc989b5c06..a8bebb52df78 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c @@ -2250,7 +2250,8 @@ static void nfs4_xdr_enc_close(struct rpc_rqst *req, struct xdr_stream *xdr, encode_sequence(xdr, &args->seq_args, &hdr); encode_putfh(xdr, args->fh, &hdr); encode_close(xdr, args, &hdr); - encode_getfattr(xdr, args->bitmask, &hdr); + if (args->bitmask != NULL) + encode_getfattr(xdr, args->bitmask, &hdr); encode_nops(&hdr); }