From patchwork Mon Nov 14 20:55:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 9428379 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 821036047D for ; Mon, 14 Nov 2016 20:55:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F3D028A66 for ; Mon, 14 Nov 2016 20:55:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7411128AE0; Mon, 14 Nov 2016 20:55:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2994628A66 for ; Mon, 14 Nov 2016 20:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933399AbcKNUzo (ORCPT ); Mon, 14 Nov 2016 15:55:44 -0500 Received: from mail-it0-f65.google.com ([209.85.214.65]:33781 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932755AbcKNUzn (ORCPT ); Mon, 14 Nov 2016 15:55:43 -0500 Received: by mail-it0-f65.google.com with SMTP id c20so14364334itb.0 for ; Mon, 14 Nov 2016 12:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=RGWQIEROADZ9ehPst3KpilDGdBuc5zP1ciliHIn2EX0=; b=PxXN4s9lZUjxnYxHojHjkUkK8jBCgmEplZzkxvqOZd6m3dKAYUdngbX9TPoRowVNh/ dYlceuR21cEGY0Wz5kjEVR7ukRFnVxyNEoUEcX6YwD7hA7CB5LGz+6AuqS5M3pKEvMlb 5+nV0HpHFVKUi5vkF2DL0jfoXXmsdtBrY6z5ClG4ds6RKPQRVSfYU5POoFpXOLoETbVY imHQGPvTzcQK+890l16CWt7DrcUqkYQ52TfyNg1XTkOpRV/vVT7Wkt3h3nG1/2vIrRYl Hu3ra5HOA8SbOHr+N9F5mKg4t6IS89YP8ZrCrpsh2eFE3Zu17pchAz/at94w00kpLyIX 8yHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=RGWQIEROADZ9ehPst3KpilDGdBuc5zP1ciliHIn2EX0=; b=Ir+bimbhCZAwACtk54cK8HoeLqQOD8y44qPLlFUjUWCwLKPbuulUWet7NlMILPkTCY sV/EYCo1k+8uJAiC9vfjVzAf1EndOGNhGGR3zodFUlzMYwF4x3ywtnyXqtQiNMqcuTA5 EAnXENVky3sJGX3wKJHG9bpcueKkGvMm0m2dXOuRHlW6E4qm1jK6hT1cGiIxdrSU3Q4H eT0URYOvFTrXHkb5JUaGBouwN1HD6vz19FbqP0FqOQGSn5ozBYetfxVw9T3YaUWm4L+f cfcBaxFcjazrDR2lDVBbXhnN1MRmRN1N/xEQ3668/yNCn3XNGbHFVRhT9neDFhxNpTM0 6CdQ== X-Gm-Message-State: ABUngveji9spFa2RPhfP3bkS40+ZjaIyfas8z4PAYtQfrQo+7hB97ondwW3w14dxp051kQ== X-Received: by 10.36.94.194 with SMTP id h185mr261338itb.82.1479156942834; Mon, 14 Nov 2016 12:55:42 -0800 (PST) Received: from leira.trondhjem.org.localdomain (c-68-49-162-121.hsd1.mi.comcast.net. [68.49.162.121]) by smtp.gmail.com with ESMTPSA id o19sm118035ito.16.2016.11.14.12.55.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Nov 2016 12:55:41 -0800 (PST) From: Trond Myklebust To: linux-nfs@vger.kernel.org Subject: [PATCH v2 2/5] NFSv4: Don't ask for the change attribute when reclaiming state Date: Mon, 14 Nov 2016 15:55:32 -0500 Message-Id: <1479156935-34479-3-git-send-email-trond.myklebust@primarydata.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1479156935-34479-2-git-send-email-trond.myklebust@primarydata.com> References: <1479156935-34479-1-git-send-email-trond.myklebust@primarydata.com> <1479156935-34479-2-git-send-email-trond.myklebust@primarydata.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We don't need to ask for the change attribute when returning a delegation or recovering from a server reboot, and it could actually cause us to obtain an incorrect value if we're using a pNFS flavour that requires LAYOUTCOMMIT. Signed-off-by: Trond Myklebust --- fs/nfs/nfs4proc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 03109b69c036..1897591689f6 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -226,7 +226,6 @@ static const u32 nfs4_pnfs_open_bitmap[3] = { static const u32 nfs4_open_noattr_bitmap[3] = { FATTR4_WORD0_TYPE - | FATTR4_WORD0_CHANGE | FATTR4_WORD0_FILEID, };