[9/9] NFSD: Set *statp in success path

Message ID	160105324081.19706.8622937614272635909.stgit@klimt.1015granger.net (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=IhtM=DC=vger.kernel.org=linux-nfs-owner@kernel.org> Sender: Chuck Lever <chucklever@gmail.com> Subject: [PATCH 9/9] NFSD: Set *statp in success path From: Chuck Lever <chuck.lever@oracle.com> To: bfields@fieldses.org Cc: linux-nfs@vger.kernel.org Date: Fri, 25 Sep 2020 13:00:40 -0400 Message-ID: <160105324081.19706.8622937614272635909.stgit@klimt.1015granger.net> In-Reply-To: <160105295313.19706.13224584458290743895.stgit@klimt.1015granger.net> References: <160105295313.19706.13224584458290743895.stgit@klimt.1015granger.net> User-Agent: StGit/0.23-29-ga622f1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk
Series	nfsd_dispatch() clean up \| expand [0/9] nfsd_dispatch() clean up [1/9] nfsd: rq_lease_breaker cleanup [2/9] lockd: Replace PROC() macro with open code [3/9] NFSACL: Replace PROC() macro with open code [4/9] NFSD: Encoder and decoder functions are always present [5/9] NFSD: Clean up switch statement in nfsd_dispatch() [6/9] NFSD: Clean up stale comments in nfsd_dispatch() [7/9] NFSD: Clean up nfsd_dispatch() variables [8/9] NFSD: Refactor nfsd_dispatch() error paths [9/9] NFSD: Set *statp in success path

Message ID

160105324081.19706.8622937614272635909.stgit@klimt.1015granger.net (mailing list archive)

State

New, archived

Headers

Sender: Chuck Lever <chucklever@gmail.com>
Subject: [PATCH 9/9] NFSD: Set *statp in success path
From: Chuck Lever <chuck.lever@oracle.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org
Date: Fri, 25 Sep 2020 13:00:40 -0400
Message-ID: 
 <160105324081.19706.8622937614272635909.stgit@klimt.1015granger.net>
In-Reply-To: 
 <160105295313.19706.13224584458290743895.stgit@klimt.1015granger.net>
References: 
 <160105295313.19706.13224584458290743895.stgit@klimt.1015granger.net>
User-Agent: StGit/0.23-29-ga622f1
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Series

nfsd_dispatch() clean up | expand

Commit Message

Chuck Lever Sept. 25, 2020, 5 p.m. UTC

*statp is supposed to be set in every path through nfsd_dispatch().
The success case appears to leave *statp uninitialized.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/nfsd/nfssvc.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index d389b276aa5e..2117cc70b493 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -1063,6 +1063,7 @@  int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp)
 
 	nfsd_cache_update(rqstp, rqstp->rq_cachetype, statp + 1);
 out_cached_reply:
+	*statp = rpc_success;
 	return 1;
 
 out_too_large:

[9/9] NFSD: Set *statp in success path

Commit Message

Patch