| Message ID | 165590732434.75778.15270277193176343053.stgit@manet.1015granger.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show
Return-Path: <linux-nfs-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
by smtp.lore.kernel.org (Postfix) with ESMTP id C7F99C43334
for <linux-nfs@archiver.kernel.org>; Wed, 22 Jun 2022 14:16:38 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1358250AbiFVOQi (ORCPT <rfc822;linux-nfs@archiver.kernel.org>);
Wed, 22 Jun 2022 10:16:38 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36362 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1358367AbiFVOPx (ORCPT
<rfc822;linux-nfs@vger.kernel.org>); Wed, 22 Jun 2022 10:15:53 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9504E396A9;
Wed, 22 Jun 2022 07:15:26 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by dfw.source.kernel.org (Postfix) with ESMTPS id 3059261BD9;
Wed, 22 Jun 2022 14:15:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46E85C34114;
Wed, 22 Jun 2022 14:15:25 +0000 (UTC)
Subject: [PATCH RFC 24/30] NFSD: Remove stale comment from nfsd_file_acquire()
From: Chuck Lever <chuck.lever@oracle.com>
To: linux-nfs@vger.kernel.org, netdev@vger.kernel.org
Cc: david@fromorbit.com, tgraf@suug.ch, jlayton@redhat.com
Date: Wed, 22 Jun 2022 10:15:24 -0400
Message-ID:
<165590732434.75778.15270277193176343053.stgit@manet.1015granger.net>
In-Reply-To:
<165590626293.75778.9843437418112335153.stgit@manet.1015granger.net>
References:
<165590626293.75778.9843437418112335153.stgit@manet.1015granger.net>
User-Agent: StGit/1.5.dev2+g9ce680a5
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org
|
| Series |
Overhaul NFSD filecache
|
expand
|
diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c index 23c51b95d2a2..ae813e6f645f 100644 --- a/fs/nfsd/filecache.c +++ b/fs/nfsd/filecache.c @@ -992,7 +992,6 @@ nfsd_do_file_acquire(struct svc_rqst *rqstp, struct svc_fh *fhp, unsigned int hashval; bool retry = true; - /* FIXME: skip this if fh_dentry is already set? */ status = fh_verify(rqstp, fhp, S_IFREG, may_flags|NFSD_MAY_OWNER_OVERRIDE); if (status != nfs_ok)
I tried the change suggested by the comment, and things broke. IMO that demonstrates the necessity of leaving the fh_verify() call in place. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> --- fs/nfsd/filecache.c | 1 - 1 file changed, 1 deletion(-)