From patchwork Thu Jun 23 20:30:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. Bruce Fields" X-Patchwork-Id: 913782 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5NKQCqD001412 for ; Thu, 23 Jun 2011 20:30:17 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932973Ab1FWUaQ (ORCPT ); Thu, 23 Jun 2011 16:30:16 -0400 Received: from fieldses.org ([174.143.236.118]:57006 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932831Ab1FWUaP (ORCPT ); Thu, 23 Jun 2011 16:30:15 -0400 Received: from bfields by fieldses.org with local (Exim 4.72) (envelope-from ) id 1QZqXU-0003Ww-Ul; Thu, 23 Jun 2011 16:30:13 -0400 Date: Thu, 23 Jun 2011 16:30:12 -0400 From: "J. Bruce Fields" To: Tigran Mkrtchyan Cc: linux-nfs@vger.kernel.org, Trond Myklebust Subject: Re: autoload rpcsec_gss_krb5 Message-ID: <20110623203012.GD12357@fieldses.org> References: <20110622213209.GA3010@fieldses.org> <20110623155947.GC8911@fieldses.org> <20110623201117.GB12357@fieldses.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110623201117.GB12357@fieldses.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 23 Jun 2011 20:30:17 +0000 (UTC) On Thu, Jun 23, 2011 at 04:11:17PM -0400, J. Bruce Fields wrote: > On Thu, Jun 23, 2011 at 10:06:14PM +0200, Tigran Mkrtchyan wrote: > > I recall a discussion at connectaton 2010, where Peter Staubach from > > RedHat ( at that time ) > > requested a way to disable pNFS without rebuilding the kernel. > > > > Probably that's why autoload is not implemented. > > Well, autoload *is* implemented, you just have to add an alias command > to modprobe.conf before it'll work. > > And if we embed the alias in the module instead, it will still be > possible to disable autloading by adding a "backlist " to > modproble.conf. > > So I don't *think* that's the issue, unless I've missed something. So can we just do this? (Untested.) --b. commit 8b3065071b5469c428d70052c80f1df3cb398da6 Author: J. Bruce Fields Date: Thu Jun 23 16:15:39 2011 -0400 pnfs: simplify pnfs files module autoloading Embed the necessary alias into the module rather than waiting for someone to add it to /etc/modprobe.conf Signed-off-by: J. Bruce Fields --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c index 4269088..eb65f82 100644 --- a/fs/nfs/nfs4filelayout.c +++ b/fs/nfs/nfs4filelayout.c @@ -896,5 +896,7 @@ static void __exit nfs4filelayout_exit(void) pnfs_unregister_layoutdriver(&filelayout_type); } +MODULE_ALIAS("nfs-layouttype4-1"); + module_init(nfs4filelayout_init); module_exit(nfs4filelayout_exit);